Bug 204169 - Add build flag for stale-while-revalidate
Summary: Add build flag for stale-while-revalidate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 201461
  Show dependency tree / graph
 
Reported: 2019-11-13 12:08 PST by Rob Buis
Modified: 2020-01-21 14:34 PST (History)
15 users (show)

See Also:

Attachments
Patch (61.34 KB, patch)
2019-11-13 12:12 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (60.45 KB, patch)
2020-01-13 08:08 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (61.32 KB, patch)
2020-01-21 10:20 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (61.36 KB, patch)
2020-01-21 11:07 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (60.63 KB, patch)
2020-01-21 11:56 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2019-11-13 12:08:02 PST 
Add build flag for stale-while-revalidate to make it independent from the NETWORK_CACHE_SPECULATIVE_REVALIDATION build flag.
Comment 1 Rob Buis 2019-11-13 12:12:03 PST 
Created attachment 383479 [details]
Patch
Comment 2 youenn fablet 2019-11-13 15:22:00 PST 
Will NETWORK_CACHE_STALE_WHILE_REVALIDATE without NETWORK_CACHE_SPECULATIVE_REVALIDATION compile?
Comment 3 Rob Buis 2019-11-14 01:45:24 PST 
(In reply to youenn fablet from comment #2)
> Will NETWORK_CACHE_STALE_WHILE_REVALIDATE without
> NETWORK_CACHE_SPECULATIVE_REVALIDATION compile?

Yes, I just tried it, and the tests pass as well.
Comment 4 Rob Buis 2020-01-13 08:08:07 PST 
Created attachment 387528 [details]
Patch
Comment 5 Rob Buis 2020-01-13 09:10:46 PST 
Comment on attachment 387528 [details]
Patch

This still seems useful to me.
Comment 6 youenn fablet 2020-01-21 04:28:47 PST 
Comment on attachment 387528 [details]
Patch

Can you verify this is compiling with the flag off?
Comment 7 Rob Buis 2020-01-21 10:20:12 PST 
Created attachment 388316 [details]
Patch
Comment 8 Rob Buis 2020-01-21 11:07:09 PST 
Created attachment 388325 [details]
Patch
Comment 9 Rob Buis 2020-01-21 11:56:52 PST 
Created attachment 388330 [details]
Patch
Comment 10 Rob Buis 2020-01-21 12:46:27 PST 
(In reply to youenn fablet from comment #6)
> Comment on attachment 387528 [details]
> Patch
> 
> Can you verify this is compiling with the flag off?

Good point, there were some unused param errors, fixed now.
Comment 11 WebKit Commit Bot 2020-01-21 14:32:27 PST 
The commit-queue encountered the following flaky tests while processing attachment 388330 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2020-01-21 14:33:08 PST 
Comment on attachment 388330 [details]
Patch

Clearing flags on attachment: 388330

Committed r254883: <https://trac.webkit.org/changeset/254883>
Comment 13 WebKit Commit Bot 2020-01-21 14:33:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2020-01-21 14:34:20 PST 
<rdar://problem/58774042>