Bug 203935 - Web Inspector: Timelines: add a marker for when a stop was requested
Summary: Web Inspector: Timelines: add a marker for when a stop was requested
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on: 196778
Blocks: 204827
  Show dependency treegraph
Reported: 2019-11-06 17:47 PST by Devin Rousso
Modified: 2019-12-03 17:30 PST (History)
5 users (show)

See Also:

Patch (7.92 KB, patch)
2019-11-06 17:50 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (187.71 KB, image/png)
2019-11-06 17:50 PST, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-11-06 17:47:06 PST
After r244195, the Web Inspector frontend doesn't stop updating the current time marker until after it receives all of the corresponding `*.trackingComplete` events.  This means that sometimes, the current time marker can move far past the time at which the stop was requested, such as if there's a blocking script (e.g. <https://wkwebviewtest.surge.sh>).  We should indicate where the stop was requested, as that is often right after a particular issue is reproduced during a timeline recording (rather than have the user try to figure out (or worse, guess) where they stopped).

It's still useful to have the current time marker continue updating, as we should show all the information we have about captured things, such as blocking scripts.
Comment 1 Devin Rousso 2019-11-06 17:50:35 PST
Created attachment 382993 [details]
Comment 2 Devin Rousso 2019-11-06 17:50:49 PST
Created attachment 382994 [details]
[Image] After Patch is applied
Comment 3 WebKit Commit Bot 2019-11-07 12:02:31 PST
Comment on attachment 382993 [details]

Clearing flags on attachment: 382993

Committed r252199: <https://trac.webkit.org/changeset/252199>
Comment 4 WebKit Commit Bot 2019-11-07 12:02:34 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-11-07 12:03:23 PST