WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196778
Web Inspector: Timelines: can't reliably stop/start a recording
https://bugs.webkit.org/show_bug.cgi?id=196778
Summary
Web Inspector: Timelines: can't reliably stop/start a recording
Devin Rousso
Reported
2019-04-10 12:56:02 PDT
Sometimes you can't reliably stop/start a timeline recording by clicking the button or hitting the spacebar. # STEPS TO REPRODUCE: 1. inspect <
https://wkwebviewtest.surge.sh
> 2. go to the Timelines tab 3. reload the page, which will trigger a timeline recording (make sure "Stop recording once page loads" is NOT checked) 4. when the recording stops after 2s, immediately click the record button to resume the recording => recording doesn't always resume.
Attachments
Patch
(70.67 KB, patch)
2019-04-10 13:38 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(89.69 KB, patch)
2019-04-11 11:43 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(89.69 KB, patch)
2019-04-11 13:19 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(89.69 KB, patch)
2019-04-11 13:26 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2019-04-10 12:56:24 PDT
<
rdar://problem/47606798
>
Devin Rousso
Comment 2
2019-04-10 13:38:25 PDT
Created
attachment 367156
[details]
Patch Patch to see how bots like the new state system.
EWS Watchlist
Comment 3
2019-04-10 13:40:44 PDT
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
WebKit Commit Bot
Comment 4
2019-04-10 15:49:00 PDT
Comment on
attachment 367156
[details]
Patch Clearing flags on attachment: 367156 Committed
r244158
: <
https://trac.webkit.org/changeset/244158
>
WebKit Commit Bot
Comment 5
2019-04-10 15:49:01 PDT
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 6
2019-04-11 08:41:33 PDT
It looks like the changes in
https://trac.webkit.org/changeset/244158/webkit
has caused 8 test failures: inspector/timeline/line-column.html inspector/timeline/timeline-event-CancelAnimationFrame.html inspector/timeline/timeline-event-FireAnimationFrame.html inspector/timeline/timeline-event-RequestAnimationFrame.html inspector/timeline/timeline-event-TimerFire.html inspector/timeline/timeline-event-TimerInstall.html inspector/timeline/timeline-event-TimerRemove.html inspector/timeline/timeline-recording.html These tests are effecting all of Mac. Can this be resolved quickly? Diff of inspector/timeline/line-column.html:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244167%20(10623)/inspector/timeline/line-column-diff.txt
History of inspector/timeline/line-column.html:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2Fline-column.html
Truitt Savell
Comment 7
2019-04-11 10:45:10 PDT
Reverted
r244158
for reason: Casued 8 inspector/timeline/ test failures. Committed
r244191
: <
https://trac.webkit.org/changeset/244191
>
Devin Rousso
Comment 8
2019-04-11 11:43:29 PDT
Created
attachment 367230
[details]
Patch
WebKit Commit Bot
Comment 9
2019-04-11 13:18:37 PDT
Comment hidden (obsolete)
Comment on
attachment 367230
[details]
Patch Rejecting
attachment 367230
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 367230, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output:
https://webkit-queues.webkit.org/results/11844142
Devin Rousso
Comment 10
2019-04-11 13:19:54 PDT
Created
attachment 367235
[details]
Patch
WebKit Commit Bot
Comment 11
2019-04-11 13:22:21 PDT
Comment hidden (obsolete)
Comment on
attachment 367235
[details]
Patch Rejecting
attachment 367235
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 367235, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output:
https://webkit-queues.webkit.org/results/11844224
Devin Rousso
Comment 12
2019-04-11 13:26:16 PDT
Created
attachment 367236
[details]
Patch
WebKit Commit Bot
Comment 13
2019-04-11 14:06:53 PDT
Comment on
attachment 367236
[details]
Patch Clearing flags on attachment: 367236 Committed
r244195
: <
https://trac.webkit.org/changeset/244195
>
WebKit Commit Bot
Comment 14
2019-04-11 14:06:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug