Bug 203829 - EWS should report test failures from clean-tree to results.webkit.org
Summary: EWS should report test failures from clean-tree to results.webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-04 15:16 PST by Aakash Jain
Modified: 2019-11-05 13:36 PST (History)
5 users (show)

See Also:


Attachments
Patch (20.77 KB, patch)
2019-11-04 17:08 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-04 15:16:07 PST
EWS should report data for the test run which EWS does without patch (test runs on clean tree). e.g.: run-layout-tests-without-patch step in https://ews-build.webkit.org/#/builders/24/builds/3740 can report results.

This might help us in scenarios where the test failures are noticed on EWS bots on clean tree, but not on bugs.webkit.org (e.g.: https://bugs.webkit.org/show_bug.cgi?id=203686,  https://bugs.webkit.org/show_bug.cgi?id=203732 and https://bugs.webkit.org/show_bug.cgi?id=203792).
Comment 1 Aakash Jain 2019-11-04 17:08:02 PST
Created attachment 382791 [details]
Patch
Comment 2 Jonathan Bedard 2019-11-04 18:09:12 PST
Comment on attachment 382791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382791&action=review

> Tools/BuildSlaveSupport/ews-build/loadConfig.py:49
> +    results_server_api_key = passwords.get('results-server-api-key')

How do passwords for EWS work? Expected to see a json edit somewhere here....

We can talk about this offline.

> Tools/BuildSlaveSupport/ews-build/steps.py:1466
> +    def start(self):

Don't think we set logEnviron to false for API tests
Comment 3 Aakash Jain 2019-11-05 06:44:15 PST
(In reply to Jonathan Bedard from comment #2)
> How do passwords for EWS work?
It works similar to build.webkit.org

> Don't think we set logEnviron to false for API tests
It was already disabled in http://trac.webkit.org/changeset/246882/webkit
Comment 4 Jonathan Bedard 2019-11-05 09:41:47 PST
(In reply to Aakash Jain from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> > How do passwords for EWS work?
> It works similar to build.webkit.org
> 

Make sure that the master has access to the API key before deploying, otherwise every EWS run will fail

> > Don't think we set logEnviron to false for API tests
> It was already disabled in http://trac.webkit.org/changeset/246882/webkit
Comment 5 Radar WebKit Bug Importer 2019-11-05 13:24:22 PST
<rdar://problem/56916405>
Comment 6 WebKit Commit Bot 2019-11-05 13:36:51 PST
Comment on attachment 382791 [details]
Patch

Clearing flags on attachment: 382791

Committed r252075: <https://trac.webkit.org/changeset/252075>
Comment 7 WebKit Commit Bot 2019-11-05 13:36:53 PST
All reviewed patches have been landed.  Closing bug.