Bug 203829 – EWS should report test failures from clean-tree to results.webkit.org

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

EWS should report data for the test run which EWS does without patch (test runs on clean tree). e.g.: run-layout-tests-without-patch step in https://ews-build.webkit.org/#/builders/24/builds/3740 can report results.

This might help us in scenarios where the test failures are noticed on EWS bots on clean tree, but not on bugs.webkit.org (e.g.: https://bugs.webkit.org/show_bug.cgi?id=203686,  https://bugs.webkit.org/show_bug.cgi?id=203732 and https://bugs.webkit.org/show_bug.cgi?id=203792).

[Aakash Jain]

Created attachment 382791 [details]
Patch

[Jonathan Bedard]

Comment on attachment 382791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382791&action=review

> Tools/BuildSlaveSupport/ews-build/loadConfig.py:49
> +    results_server_api_key = passwords.get('results-server-api-key')

How do passwords for EWS work? Expected to see a json edit somewhere here....

We can talk about this offline.

> Tools/BuildSlaveSupport/ews-build/steps.py:1466
> +    def start(self):

Don't think we set logEnviron to false for API tests

[Aakash Jain]

(In reply to Jonathan Bedard from comment #2)
> How do passwords for EWS work?
It works similar to build.webkit.org

> Don't think we set logEnviron to false for API tests
It was already disabled in http://trac.webkit.org/changeset/246882/webkit

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> > How do passwords for EWS work?
> It works similar to build.webkit.org
> 

Make sure that the master has access to the API key before deploying, otherwise every EWS run will fail

> > Don't think we set logEnviron to false for API tests
> It was already disabled in http://trac.webkit.org/changeset/246882/webkit

[Radar WebKit Bug Importer]

<rdar://problem/56916405>

[WebKit Commit Bot]

Comment on attachment 382791 [details]
Patch

Clearing flags on attachment: 382791

Committed r252075: <https://trac.webkit.org/changeset/252075>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Aakash Jain]

We disabled the reporting (before it was deployed on server) in https://bugs.webkit.org/show_bug.cgi?id=204369

[Jonathan Bedard]

Re-opening for pull request https://github.com/WebKit/WebKit/pull/7362

[EWS]

Committed 257789@main (23a93ba0cddf): <https://commits.webkit.org/257789@main>

Reviewed commits have been landed. Closing PR #7362 and removing active labels.