RESOLVED FIXED202639
results.webkit.org: Start reporting results 
https://bugs.webkit.org/show_bug.cgi?id=202639
Summary results.webkit.org: Start reporting results
Jonathan Bedard
Reported 2019-10-07 09:13:08 PDT
We should start reporting test results to the new results.webkit.org. To do this, we have to pass an API key through from the master to each test run which uploads results.
Attachments
Patch (9.12 KB, patch)
2019-10-07 09:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (13.17 KB, patch)
2019-10-08 17:25 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (13.14 KB, patch)
2019-10-09 09:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (13.14 KB, patch)
2019-10-09 13:33 PDT, Jonathan Bedard 		dewei_zhu: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-07 09:58:24 PDT
Created attachment 380335 [details] Patch
dewei_zhu
Comment 2 2019-10-07 12:04:29 PDT
Comment on attachment 380335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380335&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:52 > + results_server_api_key = passwords.get('RESULTS_SERVER_API_KEY') We usually use lower case for config json keys?
Jonathan Bedard
Comment 3 2019-10-07 13:07:35 PDT
Committed r250784: <https://trac.webkit.org/changeset/250784>
Radar WebKit Bug Importer
Comment 4 2019-10-07 13:08:18 PDT
<rdar://problem/56047710>
Matt Lewis
Comment 5 2019-10-08 12:38:49 PDT
Reverted r250784 for reason: Broke running layout tests. Committed r250851: <https://trac.webkit.org/changeset/250851>
Jonathan Bedard
Comment 6 2019-10-08 12:42:20 PDT
(In reply to Matt Lewis from comment #5) > Reverted r250784 for reason: > > Broke running layout tests. > > Committed r250851: <https://trac.webkit.org/changeset/250851> This was at my request. Don't want to be rushed when root-causing this failure.
Jonathan Bedard
Comment 7 2019-10-08 17:25:33 PDT
Created attachment 380483 [details] Patch
Jonathan Bedard
Comment 8 2019-10-09 09:03:43 PDT
Created attachment 380536 [details] Patch
Jonathan Bedard
Comment 9 2019-10-09 13:33:37 PDT
Created attachment 380561 [details] Patch
dewei_zhu
Comment 10 2019-10-09 14:09:24 PDT
Comment on attachment 380561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380561&action=review > Tools/Scripts/webkitpy/results/upload_unittest.py:129 > + with mock.patch('requests.post', new=lambda url, headers={}, data={}: self.MockResponse()): Is this syntax valid? `data={}: self.MockResponse()`?
dewei_zhu
Comment 11 2019-10-09 14:10:55 PDT
Comment on attachment 380561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380561&action=review >> Tools/Scripts/webkitpy/results/upload_unittest.py:129 >> + with mock.patch('requests.post', new=lambda url, headers={}, data={}: self.MockResponse()): > > Is this syntax valid? `data={}: self.MockResponse()`? Never mind. Missed `lambda`
Jonathan Bedard
Comment 12 2019-10-10 07:47:15 PDT
Committed r250966: <https://trac.webkit.org/changeset/250966>
Note You need to log in before you can comment on or make changes to this bug.