RESOLVED FIXED 203800
[LFC][MarginCollapsing] Add Line::isConsideredEmpty 
https://bugs.webkit.org/show_bug.cgi?id=203800
Summary [LFC][MarginCollapsing] Add Line::isConsideredEmpty
zalan
Reported 2019-11-03 20:33:27 PST
https://www.w3.org/TR/CSS22/visuren.html#inline-formatting Line boxes that contain no text, no preserved white space, no inline elements with non-zero margins, padding, or borders, and no other in-flow content (such as images, inline blocks or inline tables), and do not end with a preserved newline must be treated as zero-height line boxes for the purposes of determining the positions of any elements inside of them, and must be treated as not existing for any other purpose. Note that it does not necessarily mean visually non-empty line. <span style="font-size: 0px">this is still considered non-emptyine</span>
Attachments
Patch (7.98 KB, patch)
2019-11-03 20:39 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-03 20:33:37 PST
<rdar://problem/56854192>
zalan
Comment 2 2019-11-03 20:39:50 PST
Created attachment 382715 [details] Patch
WebKit Commit Bot
Comment 3 2019-11-06 10:08:17 PST
The commit-queue encountered the following flaky tests while processing attachment 382715 [details]: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html bug 203878 (author: mmaxfield@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2019-11-06 10:08:23 PST
The commit-queue encountered the following flaky tests while processing attachment 382715 [details]: webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html bug 203878 (author: mmaxfield@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2019-11-06 13:02:08 PST
Comment on attachment 382715 [details] Patch Clearing flags on attachment: 382715 Committed r252143: <https://trac.webkit.org/changeset/252143>
WebKit Commit Bot
Comment 6 2019-11-06 13:02:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.