Bug 203747 - [ews] Improve summary string when there are flaky failures in API tests
Summary: [ews] Improve summary string when there are flaky failures in API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-01 10:56 PDT by Aakash Jain
Modified: 2019-11-01 13:56 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2019-11-01 11:32 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-01 10:56:13 PDT
Improve EWS summary string when there are flaky failures in API tests, but no pre-existing test failures on trunk.

e.g.: https://ews-build.webkit.org/#/builders/9/builds/11297 say "Found 0 pre-existing API test failure: ". This string should only be displayed if there are pre-existing API test failures.
Comment 1 Aakash Jain 2019-11-01 11:32:27 PDT
Created attachment 382603 [details]
Patch
Comment 2 Aakash Jain 2019-11-01 11:34:08 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/4/builds/72
Comment 3 WebKit Commit Bot 2019-11-01 13:54:47 PDT
The commit-queue encountered the following flaky tests while processing attachment 382603 [details]:

requestidlecallback/requestidlecallback-document-gc.html bug 203745 (author: rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2019-11-01 13:55:31 PDT
Comment on attachment 382603 [details]
Patch

Clearing flags on attachment: 382603

Committed r251938: <https://trac.webkit.org/changeset/251938>
Comment 5 WebKit Commit Bot 2019-11-01 13:55:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-01 13:56:15 PDT
<rdar://problem/56827460>