Bug 203689 - AX: Restrict WebSpeech voices to built-in voices only
Summary: AX: Restrict WebSpeech voices to built-in voices only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-31 12:19 PDT by chris fleizach
Modified: 2019-11-01 17:54 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.68 KB, patch)
2019-10-31 12:36 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2019-10-31 12:19:47 PDT 
Restrict the list of voices to built-in voices when requested over the web to reduce fingerprinting abilities.

<rdar://problem/56232533>
Comment 1 chris fleizach 2019-10-31 12:36:15 PDT 
Created attachment 382486 [details]
patch
Comment 2 chris fleizach 2019-10-31 12:36:44 PDT 
Per can you review?
Comment 3 Per Arne Vollan 2019-11-01 16:30:46 PDT 
Comment on attachment 382486 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382486&action=review

> Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:268
> +        if (voice.quality == AVSpeechSynthesisVoiceQualityDefault)

Does only the built-in voices have this quality?
Comment 4 chris fleizach 2019-11-01 16:31:35 PDT 
Comment on attachment 382486 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382486&action=review

>> Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:268
>> +        if (voice.quality == AVSpeechSynthesisVoiceQualityDefault)
> 
> Does only the built-in voices have this quality?

yes
Comment 5 Per Arne Vollan 2019-11-01 16:45:34 PDT 
Comment on attachment 382486 [details]
patch

R=me.
Comment 6 WebKit Commit Bot 2019-11-01 17:53:19 PDT 
The commit-queue encountered the following flaky tests while processing attachment 382486 [details]:

imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg bug 203172 (author: sabouhallawa@apple.com)
imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-11-01 17:54:11 PDT 
Comment on attachment 382486 [details]
patch

Clearing flags on attachment: 382486

Committed r251960: <https://trac.webkit.org/changeset/251960>
Comment 8 WebKit Commit Bot 2019-11-01 17:54:13 PDT 
All reviewed patches have been landed.  Closing bug.