WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 203689
AX: Restrict WebSpeech voices to built-in voices only
https://bugs.webkit.org/show_bug.cgi?id=203689
Summary
AX: Restrict WebSpeech voices to built-in voices only
chris fleizach
Reported
2019-10-31 12:19:47 PDT
Restrict the list of voices to built-in voices when requested over the web to reduce fingerprinting abilities. <
rdar://problem/56232533
>
Attachments
patch
(1.68 KB, patch)
2019-10-31 12:36 PDT
,
chris fleizach
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
chris fleizach
Comment 1
2019-10-31 12:36:15 PDT
Created
attachment 382486
[details]
patch
chris fleizach
Comment 2
2019-10-31 12:36:44 PDT
Per can you review?
Per Arne Vollan
Comment 3
2019-11-01 16:30:46 PDT
Comment on
attachment 382486
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=382486&action=review
> Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:268 > + if (voice.quality == AVSpeechSynthesisVoiceQualityDefault)
Does only the built-in voices have this quality?
chris fleizach
Comment 4
2019-11-01 16:31:35 PDT
Comment on
attachment 382486
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=382486&action=review
>> Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:268 >> + if (voice.quality == AVSpeechSynthesisVoiceQualityDefault) > > Does only the built-in voices have this quality?
yes
Per Arne Vollan
Comment 5
2019-11-01 16:45:34 PDT
Comment on
attachment 382486
[details]
patch R=me.
WebKit Commit Bot
Comment 6
2019-11-01 17:53:19 PDT
The commit-queue encountered the following flaky tests while processing
attachment 382486
[details]
: imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg
bug 203172
(author:
sabouhallawa@apple.com
) imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html
bug 202003
(author:
youennf@gmail.com
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7
2019-11-01 17:54:11 PDT
Comment on
attachment 382486
[details]
patch Clearing flags on attachment: 382486 Committed
r251960
: <
https://trac.webkit.org/changeset/251960
>
WebKit Commit Bot
Comment 8
2019-11-01 17:54:13 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug