Bug 203675 - [GLIB]] Several shape-outside tests are failing
Summary: [GLIB]] Several shape-outside tests are failing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-31 06:31 PDT by Miguel Gomez
Modified: 2020-06-09 02:05 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2019-10-31 06:31:31 PDT
These tests fail both on gtk and wpe since added on r251699:
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-010.html [ Failure ]
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-011.html [ Failure ]
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-012.html [ Failure ]
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-013.html [ Failure ]
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-014.html [ Failure ]
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-015.html [ Failure ]
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-016.html [ Failure ]
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-017.html [ Failure ]

From these, numbers 010 to 013 fail probably because of https://bugs.webkit.org/show_bug.cgi?id=203240, as they create a shape from an image. Numbers 014 to 017 must have other reason cause they don't use images to create the shape.

Diffs attached below.

imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-010.html [ Failure ]
diff
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-010-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-010-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 278
 The test passes if the short green horizontal bars are the right of the circle, the long green bar is beneath the circle, and no bars intersect the circle. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXXXXXXXXXXX
 
-PASS CSS Test: Shape from image - url(), alpha channel, opacity 0 
+FAIL CSS Test: Shape from image - url(), alpha channel, opacity 0 Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 278
 

imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-011.html [ Failure ]
diff
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-011-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-011-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 244 +/- 2 but got 314
 The test passes if the green horizontal bars are to the right of the circle, and no bars intersect the circle's shadow. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX
 
-PASS CSS Test: Shape from image - url(), alpha channel, opacity > 0 
+FAIL CSS Test: Shape from image - url(), alpha channel, opacity > 0 Error: assert_approx_equals: Line 1 is positioned properly expected 244 +/- 2 but got 314
 

imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-012.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-012-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-012-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 277
 The test passes if the short green horizontal bars are the right of the circle, all intersect the shadow, none intersect the circle and the long green bar is beneath the circle. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXXXXXXXXXXX
 
-PASS CSS Test: Shape from image - shape-image-threshold - 0.9 
+FAIL CSS Test: Shape from image - shape-image-threshold - 0.9 Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 277
 


imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-013.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-013-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-013-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 214 +/- 2 but got 288
 The test passes if the short green horizontal bars are the right of the circle, the long green bar is beneath the circle, and no bars intersect the circle. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXXXXXXXXX
 
-PASS CSS Test: Shape from image - shape-margin 
+FAIL CSS Test: Shape from image - shape-margin Error: assert_approx_equals: Line 1 is positioned properly expected 214 +/- 2 but got 288
 


imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-014.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-014-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-014-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 198 +/- 3 but got 269
 The test passes if the short green horizontal bars are the right of the shape, the long green bar is beneath it, and no bars intersect it. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXXXXXXXXXXX
 
-PASS CSS Test: Shape from box value - margin-box 
+FAIL CSS Test: Shape from box value - margin-box Error: assert_approx_equals: Line 1 is positioned properly expected 198 +/- 3 but got 269
 


imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-015.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-015-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-015-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 282
 The test passes if the short green horizontal bars are the right of the shape, the long green bar is beneath it, and no bars intersect it. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXXXXXXXXXXX
 
-PASS CSS Test: Shape from box value - border-box 
+FAIL CSS Test: Shape from box value - border-box Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 282
 


imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-016.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-016-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-016-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 282
 The test passes if the short green horizontal bars are the right of the shape, the long green bar is beneath it, and no bars intersect it. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXXXXXXXXXXX
 
-PASS CSS Test: Shape from box value - padding-box 
+FAIL CSS Test: Shape from box value - padding-box Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 282
 


imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-017.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-017-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-017-actual.txt
@@ -1,6 +1,7 @@
+CONSOLE MESSAGE: line 3082: Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 282
 The test passes if the short green horizontal bars are the right of the shape, the long green bar is beneath it, and no bars intersect it. There should be no red.
 
 XXXXXX XXXXXX XXXXXX XXXXXX XXXXXX XXXXXXXXXXXXXXX
 
-PASS CSS Test: Shape from box value - content-box 
+FAIL CSS Test: Shape from box value - content-box Error: assert_approx_equals: Line 1 is positioned properly expected 207 +/- 2 but got 282
Comment 1 Miguel Gomez 2019-10-31 06:35:59 PDT
Two more related tests failing:
imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-margin-001.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-margin-001-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-margin-001-actual.txt
@@ -18,8 +18,8 @@
 PASS 10pt - computed 
 PASS 10pc - computed 
 PASS 10em - computed 
-PASS 10ex - computed 
-PASS 10ch - computed 
+FAIL 10ex - computed assert_equals: expected "128px" but got "73.438px"
+FAIL 10ch - computed assert_equals: expected "160px" but got "80px"
 PASS 10rem - computed 
 PASS 10vw - computed 
 PASS 10vh - computed 


imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html [ Failure ]
diff:
--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000-actual.txt
@@ -5,7 +5,7 @@
 PASS Fixed units - inline 
 PASS Percentage units - inline 
 PASS 0-valued - computed 
-PASS Font relative units - computed 
+FAIL Font relative units - computed assert_equals: expected "polygon(16px 12.8px, 16px 16px)" but got "polygon(16px 7.344px, 8px 16px)"
 PASS View relative units - computed 
 PASS Fixed units - computed 
 PASS Percentage units - computed
Comment 2 Diego Pino 2020-03-13 22:09:32 PDT
imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-012.html is a flaky failure since:

r257873                       TEXT (Expected: FAIL)
[r257874-r257878]             UNKNOWN
r257879                       PASS (Expected: FAIL)