Bug 203240 - [GTK][WPE] shape-outside property defined from an animated image doesn't work properly
Summary: [GTK][WPE] shape-outside property defined from an animated image doesn't work...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2019-10-22 01:41 PDT by Miguel Gomez
Modified: 2020-05-08 02:16 PDT (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2019-10-22 01:41:29 PDT
According to the spec, when using an animated image, the shape must be generated from the first frame. But this is not happening and the shape is updated following the animation. I think this might be an issue in multiplatform code: in order to create the shape, BitmapImage::draw() is called, which starts the animation, and I don't see how the animation is stopped at any point. With every new frame decoded RenderBox::imageChanged() gets called, which invalidates the shape and it's created again from the next frame. We could avoid decoding the animation completely, and just decode the first frame.
This is causing that tests
are failing both on GTK and WPE ports. They are passing for Apple, but I'm not sure it's because it's working properly. Gotta look into it.