Bug 203416 - [Web Animations] imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html and imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html are failures
Summary: [Web Animations] imported/w3c/web-platform-tests/css/css-transitions/before-l...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 203477
  Show dependency treegraph
 
Reported: 2019-10-25 08:17 PDT by Antoine Quint
Modified: 2020-06-29 16:45 PDT (History)
9 users (show)

See Also:


Attachments
Update TestExpectations (1.56 KB, patch)
2020-06-29 09:29 PDT, Karl Rackler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-10-25 08:17:09 PDT
The test imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html added as part of bug 203291 is a failure on iOS.
Comment 1 Antoine Quint 2019-10-25 08:20:27 PDT
Also, imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html.
Comment 2 Truitt Savell 2019-10-25 11:23:37 PDT
Marked test as failing as part of https://trac.webkit.org/changeset/251597/webkit
Comment 3 Antoine Quint 2019-10-28 00:57:11 PDT
These also fail on GTK, added expectations in r251648.
Comment 4 Ben Nham 2020-02-13 16:56:07 PST
After https://bugs.webkit.org/show_bug.cgi?id=207516, which makes Mac first paint behave like iOS first paint, this test (before-load-001.html) will be skipped on Mac as well.

Basically what this test is doing is animating a div from 1px to 100px over 0.1s and trying to make sure the animation can start before the load event fires. But since iOS (and now Mac) don't produce a first paint until we deem the paint significantly visually non-empty, the first paint can happen at the same time as the load event fires in WebKit.

There's a comment in this test that says it tests behavior that isn't specified in the standard, so I'm not sure that the semantics of this test make sense for WebKit given our first paint policies.

The one thing to look in to here is that maybe we should be triggering an emergency paint before the load event fires on iOS and Mac, which could make the test pass.
Comment 5 Karl Rackler 2020-06-29 09:28:38 PDT
imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html is no longer failing - remove expectations

Current history is green for Mac: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fbefore-load-001.html

This test was isolated from the others in the group as one that is unexpectedly passing.
Comment 6 Karl Rackler 2020-06-29 09:29:18 PDT
Created attachment 403072 [details]
Update TestExpectations
Comment 7 Radar WebKit Bug Importer 2020-06-29 09:32:37 PDT
<rdar://problem/64893646>
Comment 8 EWS 2020-06-29 11:48:12 PDT
Committed r263672: <https://trac.webkit.org/changeset/263672>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403072 [details].
Comment 9 Ryan Haddad 2020-06-29 16:44:58 PDT
Reopening since there are still tests failing.