Bug 203291 – [Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests

[Antoine Quint]

Created attachment 381673 [details]
Patch

[youenn fablet]

Comment on attachment 381673 [details]
Patch

r=me once bots are green.

View in context: https://bugs.webkit.org/attachment.cgi?id=381673&action=review

> LayoutTests/imported/w3c/ChangeLog:9
> +        * web-platform-tests/css/css-animations/AnimationEffect-getComputedTiming.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-computed-timing-expected.txt.

If you feel like, you can add a one-liner like:
* web-platform-tests/css/css-animations: resynced.

> LayoutTests/TestExpectations:3883
> +webkit.org/b/XXXXXX imported/w3c/web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash.html [ Timeout ]

File a bug?
If it is timing out, let's skip it for now.

> LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animationevent-interface.html:7
> +<script src="../../../../../resources/testharnessreport.js"></script>

These changes are unnecessary.
Maybe this is due to the way you are running the script.
You can use --no-links-conversion to remove these changes.

[Antoine Quint]

Created attachment 381680 [details]
Patch

[Antoine Quint]

Created attachment 381702 [details]
Patch

[Antoine Quint]

Created attachment 381785 [details]
Patch

[Antoine Quint]

Created attachment 381791 [details]
Patch

[youenn fablet]

Comment on attachment 381791 [details]
Patch

r=me.
It might be nice to update TestExpectations quickly to skip some timing out tests.
Also some tests are apparently taking very long to pass. I wonder whether bots will like them.

View in context: https://bugs.webkit.org/attachment.cgi?id=381791&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animationevent-marker-pseudoelement-expected.txt:4
> +TIMEOUT AnimationEvent should have the correct pseudoElement memeber Test timed out

Let's skip this one

> LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/non-rendered-element-002-expected.txt:5
> +NOTRUN Transitions on ::marker pseudo-elements are canceled when the parent display type is no longer list-item 

Let's skip this one

> LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html:50
> +            var timeout = 60000;

Are we sure we want to run this test?

> LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-002.html:52
> +            var timeout = 60000;

Ditto.

[WebKit Commit Bot]

Comment on attachment 381791 [details]
Patch

Clearing flags on attachment: 381791

Committed r251536: <https://trac.webkit.org/changeset/251536>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56577481>

[Russell Epstein]

Multiple tests landed failing:

imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html
imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html
imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html


Test History:

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fbefore-load-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fproperties-value-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fproperties-value-auto-001.html

[Russell Epstein]

Reverted r251536 for reason:

Landed 3 Broken Tests.

Committed r251573: <https://trac.webkit.org/changeset/251573>

[Antoine Quint]

Landed again in r251591.

[Truitt Savell]

This test imported/w3c/web-platform-tests/css/css-animations/event-order.tentative.html 
is failing upon landing again.

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-animations%2Fevent-order.tentative.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/css/css-animations/event-order.tentative-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/css/css-animations/event-order.tentative-actual.txt
@@ -1,6 +1,6 @@
 
 FAIL Same events are ordered by elements assert_equals: Event #1 pseudoElements should match expected (string) "" but got (undefined) undefined
-FAIL Same events on pseudo-elements follow the prescribed order assert_equals: Event #1 pseudoElements should match expected (string) "" but got (undefined) undefined
+FAIL Same events on pseudo-elements follow the prescribed order assert_equals: Number of events received (0) should match expected number (4) (expected: animationstart, animationstart, animationstart, animationstart, actual: ) expected 4 but got 0
 FAIL Start and iteration events are ordered by time assert_equals: Event #1 types should match (expected: animationiteration, animationstart, actual: animationstart, animationiteration) expected "animationiteration" but got "animationstart"
 FAIL Iteration and end events are ordered by time assert_equals: Event #1 types should match (expected: animationiteration, animationend, actual: animationend, animationiteration) expected "animationiteration" but got "animationend"
 FAIL Start and end events are sorted correctly when fired simultaneously assert_equals: Event #1 targets should match expected Element node <div style="animation: anim 100s 2"></div> but got Element node <div style="animation: anim 100s 100s"></div>

[Truitt Savell]

(In reply to Russell Epstein from comment #11)
> Multiple tests landed failing:
> 
> imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html
> imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html
> imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-
> 001.html
> 
> 
> Test History:
> 
> https://results.webkit.org/?suite=layout-tests&suite=layout-
> tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fcss%2Fcss-transitions%2Fbefore-load-001.
> html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-
> transitions%2Fproperties-value-001.html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fcss%2Fcss-transitions%2Fproperties-value-auto-001.html

These tests are failing again too.

[Antoine Quint]

Committed r251648: <https://trac.webkit.org/changeset/251648>

[Antoine Quint]

Here's the state of the reported failures since landing again:

- imported/w3c/web-platform-tests/css/css-animations/event-order.tentative.html: newly tracked by bug 203480 in r251648.
- imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html: already tracked by bug 203416 but a new [ Failure ] expectation was added for platform/gtk in r251648.
- imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html: already tracked by bug 203305
- imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html: already tracked by bug 203416 but a new [ Failure ] expectation was added for platform/gtk in r251648.

[Truitt Savell]

Two more tests failing due to this import: 

imported/w3c/web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time.html 
imported/w3c/web-platform-tests/css/css-animations/animation-transform-pause-and-set-time.html

Both are image failure.
History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-animations%2Fanimation-opacity-pause-and-set-time.html%20imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-animations%2Fanimation-transform-pause-and-set-time.html

[Truitt Savell]

(In reply to Truitt Savell from comment #18)
> Two more tests failing due to this import: 
> 
> imported/w3c/web-platform-tests/css/css-animations/animation-opacity-pause-
> and-set-time.html 
> imported/w3c/web-platform-tests/css/css-animations/animation-transform-pause-
> and-set-time.html
> 
> Both are image failure.
> History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-
> animations%2Fanimation-opacity-pause-and-set-time.
> html%20imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-
> animations%2Fanimation-transform-pause-and-set-time.html

https://bugs.webkit.org/show_bug.cgi?id=203501 for these failures