Bug 203291 - [Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests
Summary: [Web Animations] Update WPT tests related to Web Animations and remove import...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 203477
  Show dependency treegraph
 
Reported: 2019-10-23 03:26 PDT by Antoine Quint
Modified: 2019-10-28 13:11 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.23 MB, patch)
2019-10-23 03:29 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (1.18 MB, patch)
2019-10-23 08:49 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (1.18 MB, patch)
2019-10-23 11:14 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (1.19 MB, patch)
2019-10-24 01:13 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (1.19 MB, patch)
2019-10-24 02:27 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-10-23 03:26:40 PDT
[Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests
Comment 1 Antoine Quint 2019-10-23 03:29:09 PDT
Created attachment 381673 [details]
Patch
Comment 2 youenn fablet 2019-10-23 03:34:01 PDT
Comment on attachment 381673 [details]
Patch

r=me once bots are green.

View in context: https://bugs.webkit.org/attachment.cgi?id=381673&action=review

> LayoutTests/imported/w3c/ChangeLog:9
> +        * web-platform-tests/css/css-animations/AnimationEffect-getComputedTiming.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-computed-timing-expected.txt.

If you feel like, you can add a one-liner like:
* web-platform-tests/css/css-animations: resynced.

> LayoutTests/TestExpectations:3883
> +webkit.org/b/XXXXXX imported/w3c/web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash.html [ Timeout ]

File a bug?
If it is timing out, let's skip it for now.

> LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animationevent-interface.html:7
> +<script src="../../../../../resources/testharnessreport.js"></script>

These changes are unnecessary.
Maybe this is due to the way you are running the script.
You can use --no-links-conversion to remove these changes.
Comment 3 Antoine Quint 2019-10-23 08:49:25 PDT
Created attachment 381680 [details]
Patch
Comment 4 Antoine Quint 2019-10-23 11:14:31 PDT
Created attachment 381702 [details]
Patch
Comment 5 Antoine Quint 2019-10-24 01:13:53 PDT
Created attachment 381785 [details]
Patch
Comment 6 Antoine Quint 2019-10-24 02:27:31 PDT
Created attachment 381791 [details]
Patch
Comment 7 youenn fablet 2019-10-24 05:25:45 PDT
Comment on attachment 381791 [details]
Patch

r=me.
It might be nice to update TestExpectations quickly to skip some timing out tests.
Also some tests are apparently taking very long to pass. I wonder whether bots will like them.

View in context: https://bugs.webkit.org/attachment.cgi?id=381791&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animationevent-marker-pseudoelement-expected.txt:4
> +TIMEOUT AnimationEvent should have the correct pseudoElement memeber Test timed out

Let's skip this one

> LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/non-rendered-element-002-expected.txt:5
> +NOTRUN Transitions on ::marker pseudo-elements are canceled when the parent display type is no longer list-item 

Let's skip this one

> LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html:50
> +            var timeout = 60000;

Are we sure we want to run this test?

> LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-002.html:52
> +            var timeout = 60000;

Ditto.
Comment 8 WebKit Commit Bot 2019-10-24 06:25:37 PDT
Comment on attachment 381791 [details]
Patch

Clearing flags on attachment: 381791

Committed r251536: <https://trac.webkit.org/changeset/251536>
Comment 9 WebKit Commit Bot 2019-10-24 06:25:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-10-24 06:26:18 PDT
<rdar://problem/56577481>
Comment 11 Russell Epstein 2019-10-24 16:30:38 PDT
Multiple tests landed failing:

imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html
imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html
imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html


Test History:

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fbefore-load-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fproperties-value-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fproperties-value-auto-001.html
Comment 12 Russell Epstein 2019-10-24 16:45:22 PDT
Reverted r251536 for reason:

Landed 3 Broken Tests.

Committed r251573: <https://trac.webkit.org/changeset/251573>
Comment 13 Antoine Quint 2019-10-25 08:32:20 PDT
Landed again in r251591.
Comment 14 Truitt Savell 2019-10-25 09:51:12 PDT
This test imported/w3c/web-platform-tests/css/css-animations/event-order.tentative.html 
is failing upon landing again.

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-animations%2Fevent-order.tentative.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/css/css-animations/event-order.tentative-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/css/css-animations/event-order.tentative-actual.txt
@@ -1,6 +1,6 @@
 
 FAIL Same events are ordered by elements assert_equals: Event #1 pseudoElements should match expected (string) "" but got (undefined) undefined
-FAIL Same events on pseudo-elements follow the prescribed order assert_equals: Event #1 pseudoElements should match expected (string) "" but got (undefined) undefined
+FAIL Same events on pseudo-elements follow the prescribed order assert_equals: Number of events received (0) should match expected number (4) (expected: animationstart, animationstart, animationstart, animationstart, actual: ) expected 4 but got 0
 FAIL Start and iteration events are ordered by time assert_equals: Event #1 types should match (expected: animationiteration, animationstart, actual: animationstart, animationiteration) expected "animationiteration" but got "animationstart"
 FAIL Iteration and end events are ordered by time assert_equals: Event #1 types should match (expected: animationiteration, animationend, actual: animationend, animationiteration) expected "animationiteration" but got "animationend"
 FAIL Start and end events are sorted correctly when fired simultaneously assert_equals: Event #1 targets should match expected Element node <div style="animation: anim 100s 2"></div> but got Element node <div style="animation: anim 100s 100s"></div>
Comment 15 Truitt Savell 2019-10-25 09:52:45 PDT
(In reply to Russell Epstein from comment #11)
> Multiple tests landed failing:
> 
> imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html
> imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html
> imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-
> 001.html
> 
> 
> Test History:
> 
> https://results.webkit.org/?suite=layout-tests&suite=layout-
> tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fcss%2Fcss-transitions%2Fbefore-load-001.
> html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-
> transitions%2Fproperties-value-001.html&test=imported%2Fw3c%2Fweb-platform-
> tests%2Fcss%2Fcss-transitions%2Fproperties-value-auto-001.html

These tests are failing again too.
Comment 16 Antoine Quint 2019-10-28 00:55:19 PDT
Committed r251648: <https://trac.webkit.org/changeset/251648>
Comment 17 Antoine Quint 2019-10-28 00:56:45 PDT
Here's the state of the reported failures since landing again:

- imported/w3c/web-platform-tests/css/css-animations/event-order.tentative.html: newly tracked by bug 203480 in r251648.
- imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html: already tracked by bug 203416 but a new [ Failure ] expectation was added for platform/gtk in r251648.
- imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html: already tracked by bug 203305
- imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html: already tracked by bug 203416 but a new [ Failure ] expectation was added for platform/gtk in r251648.
Comment 18 Truitt Savell 2019-10-28 10:16:13 PDT
Two more tests failing due to this import: 

imported/w3c/web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time.html 
imported/w3c/web-platform-tests/css/css-animations/animation-transform-pause-and-set-time.html

Both are image failure.
History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-animations%2Fanimation-opacity-pause-and-set-time.html%20imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-animations%2Fanimation-transform-pause-and-set-time.html
Comment 19 Truitt Savell 2019-10-28 13:11:49 PDT
(In reply to Truitt Savell from comment #18)
> Two more tests failing due to this import: 
> 
> imported/w3c/web-platform-tests/css/css-animations/animation-opacity-pause-
> and-set-time.html 
> imported/w3c/web-platform-tests/css/css-animations/animation-transform-pause-
> and-set-time.html
> 
> Both are image failure.
> History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-
> animations%2Fanimation-opacity-pause-and-set-time.
> html%20imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-
> animations%2Fanimation-transform-pause-and-set-time.html

https://bugs.webkit.org/show_bug.cgi?id=203501 for these failures