Bug 203396 - [Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface
Summary: [Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-24 20:51 PDT by Andy Estes
Modified: 2019-10-25 18:49 PDT (History)
13 users (show)

See Also:


Attachments
Patch (61.15 KB, patch)
2019-10-24 21:08 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (60.20 KB, patch)
2019-10-24 21:13 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (59.99 KB, patch)
2019-10-24 22:26 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-10-24 20:51:39 PDT
[Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface
Comment 1 Andy Estes 2019-10-24 21:08:06 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2019-10-24 21:13:19 PDT Comment hidden (obsolete)
Comment 3 Andy Estes 2019-10-24 22:26:34 PDT
Created attachment 381880 [details]
Patch
Comment 4 Alex Christensen 2019-10-25 10:32:39 PDT
Comment on attachment 381880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381880&action=review

> Source/WTF/wtf/FeatureDefines.h:222
> +#if PLATFORM(IOS)
> +#define ENABLE_PREVIEW_CONVERTER 1

No IOS_FAMILY?  This seems correct, but I'm double checking.
Comment 5 Andy Estes 2019-10-25 11:00:51 PDT
(In reply to Alex Christensen from comment #4)
> Comment on attachment 381880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381880&action=review
> 
> > Source/WTF/wtf/FeatureDefines.h:222
> > +#if PLATFORM(IOS)
> > +#define ENABLE_PREVIEW_CONVERTER 1
> 
> No IOS_FAMILY?  This seems correct, but I'm double checking.

USE_QUICK_LOOK is also just IOS.
Comment 6 WebKit Commit Bot 2019-10-25 15:17:38 PDT
The commit-queue encountered the following flaky tests while processing attachment 381880 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-10-25 15:17:46 PDT
The commit-queue encountered the following flaky tests while processing attachment 381880 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2019-10-25 18:48:12 PDT
Comment on attachment 381880 [details]
Patch

Clearing flags on attachment: 381880

Committed r251623: <https://trac.webkit.org/changeset/251623>
Comment 9 WebKit Commit Bot 2019-10-25 18:48:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-10-25 18:49:18 PDT
<rdar://problem/56639669>