Bug 203388 - [iOS] Regression(r251067) WebProcesses with service workers no longer keep their network process alive
Summary: [iOS] Regression(r251067) WebProcesses with service workers no longer keep th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-24 16:17 PDT by Chris Dumez
Modified: 2019-10-25 06:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2019-10-24 16:31 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.78 KB, patch)
2019-10-24 17:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.81 KB, patch)
2019-10-24 21:45 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-24 16:17:33 PDT
WebProcesses with service workers no longer keep their network process alive since r251067. This is causing hangs because the WebProcess gets stuck on sync IPC with the network process.
Comment 1 Chris Dumez 2019-10-24 16:31:02 PDT
Created attachment 381855 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-10-24 16:41:02 PDT
<rdar://problem/56600074>
Comment 3 Chris Dumez 2019-10-24 17:01:55 PDT
Created attachment 381860 [details]
Patch
Comment 4 Geoffrey Garen 2019-10-24 21:28:03 PDT
Comment on attachment 381860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381860&action=review

r=me

I'm surprised that our existing service worker tests don't exercise the case where you have a service worker and need to do a network load. I wonder if there's a way to test this.

> Source/WebKit/ChangeLog:14
> +        However, after r251067, there is no longer a concept of service worker process per say. Service workers

per se
Comment 5 Chris Dumez 2019-10-24 21:45:47 PDT
Created attachment 381877 [details]
Patch
Comment 6 WebKit Commit Bot 2019-10-24 23:45:40 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-10-24 23:45:48 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2019-10-25 01:49:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

media/modern-media-controls/placard-support/placard-support-pip.html bug 195249 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2019-10-25 01:49:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2019-10-25 02:49:59 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

fast/history/page-cache-webdatabase-pending-transaction.html bug 203399 (author: cdumez@apple.com)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2019-10-25 02:50:05 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2019-10-25 03:47:19 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

fast/history/page-cache-webdatabase-pending-transaction.html bug 203399 (author: cdumez@apple.com)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2019-10-25 03:47:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

The commit-queue is continuing to process your patch.
Comment 14 WebKit Commit Bot 2019-10-25 04:44:25 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

The commit-queue is continuing to process your patch.
Comment 15 WebKit Commit Bot 2019-10-25 04:44:32 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 16 WebKit Commit Bot 2019-10-25 06:01:12 PDT
Comment on attachment 381877 [details]
Patch

Clearing flags on attachment: 381877

Committed r251589: <https://trac.webkit.org/changeset/251589>
Comment 17 WebKit Commit Bot 2019-10-25 06:01:14 PDT
All reviewed patches have been landed.  Closing bug.