Bug 203388 – [iOS] Regression(r251067) WebProcesses with service workers no longer keep their network process alive

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

WebProcesses with service workers no longer keep their network process alive since r251067. This is causing hangs because the WebProcess gets stuck on sync IPC with the network process.

[Chris Dumez]

Created attachment 381855 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/56600074>

[Chris Dumez]

Created attachment 381860 [details]
Patch

[Geoffrey Garen]

Comment on attachment 381860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381860&action=review

r=me

I'm surprised that our existing service worker tests don't exercise the case where you have a service worker and need to do a network load. I wonder if there's a way to test this.

> Source/WebKit/ChangeLog:14
> +        However, after r251067, there is no longer a concept of service worker process per say. Service workers

per se

[Chris Dumez]

Created attachment 381877 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

media/modern-media-controls/placard-support/placard-support-pip.html bug 195249 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

fast/history/page-cache-webdatabase-pending-transaction.html bug 203399 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

fast/history/page-cache-webdatabase-pending-transaction.html bug 203399 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 381877 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 381877 [details]
Patch

Clearing flags on attachment: 381877

Committed r251589: <https://trac.webkit.org/changeset/251589>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.