Add more information to SRI failure console messages
Created attachment 381843 [details] Patch
Comment on attachment 381843 [details] Patch Attachment 381843 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13174705 New failing tests: js/dom/modules/module-fetch-failure-not-cached.html
Created attachment 381858 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 381843 [details] Patch r=me but please update test result expectations before landing
Created attachment 381861 [details] Patch
Comment on attachment 381861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381861&action=review > Source/WebCore/loader/SubresourceIntegrity.cpp:216 > + builder.append(". Failed integrity metadata check. "); appendLiteral > Source/WebCore/loader/SubresourceIntegrity.cpp:217 > + builder.append("Content length: "); appendLiteral > Source/WebCore/loader/SubresourceIntegrity.cpp:221 > + builder.append("(no content)"); appendLiteral > Source/WebCore/loader/SubresourceIntegrity.cpp:222 > + builder.append(", Expected content length: "); appendLiteral > Source/WebCore/loader/SubresourceIntegrity.cpp:224 > + builder.append(", Expected metadata: "); appendLiteral > Source/WebCore/loader/SubresourceIntegrity.cpp:225 > + builder.append(integrityMetadata); appendLiteral
The commit-queue encountered the following flaky tests while processing attachment 381861 [details]: The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 381861 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
(In reply to WebKit Commit Bot from comment #10) > The commit-queue encountered the following flaky tests while processing > attachment 381861 [details]: > > imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script- > element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) > The commit-queue is continuing to process your patch. Given how related this test is, I would not be surprised if this patch was the cause of the flakiness.
Comment on attachment 381861 [details] Patch Clearing flags on attachment: 381861 Committed r251582: <https://trac.webkit.org/changeset/251582>
All reviewed patches have been landed. Closing bug.
<rdar://problem/56607815>
It looks like the changes in https://trac.webkit.org/changeset/251582/webkit broke imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html on Mac wk1 history: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fscripting-1%2Fthe-script-element%2Fmodule%2Fintegrity.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 1: TypeError: Cannot load script http://localhost:8800/html/semantics/scripting-1/the-script-element/module/integrity-mismatches.js. Failed integrity metadata check. Content length: 93, Expected content length: -1, Expected metadata: sha384-doesnotmatch +CONSOLE MESSAGE: line 1: TypeError: Cannot load script http://localhost:8800/html/semantics/scripting-1/the-script-element/module/integrity-mismatches.js. Failed integrity metadata check. Content length: 93, Expected content length: 93, Expected metadata: sha384-doesnotmatch PASS The integrity attribute must have no affect on inline module scripts PASS The integrity attribute must be verified on the top-level of a module and allow it to execute when it matches
http://trac.webkit.org/r251596 fixes that test
It looks like this test is still flakey: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fscripting-1%2Fthe-script-element%2Fmodule%2Fintegrity.html&platform=ios&platform=mac Diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 1: TypeError: Cannot load script http://localhost:8800/html/semantics/scripting-1/the-script-element/module/integrity-mismatches.js. Failed integrity metadata check. Content length: 93, Expected content length: 93, Expected metadata: sha384-doesnotmatch +CONSOLE MESSAGE: line 1: TypeError: Cannot load script http://localhost:8800/html/semantics/scripting-1/the-script-element/module/integrity-mismatches.js. Failed integrity metadata check. Content length: 93, Expected content length: -1, Expected metadata: sha384-doesnotmatch PASS The integrity attribute must have no affect on inline module scripts PASS The integrity attribute must be verified on the top-level of a module and allow it to execute when it matches
http://trac.webkit.org/r251660 makes it always pass.
Is it understood why the expected content length became unreliable here?