Bug 203301 - test262-runner should be able to pass JSC a feature flag
Summary: test262-runner should be able to pass JSC a feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-23 10:19 PDT by Ross Kirsling
Modified: 2019-10-25 05:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (47.98 KB, patch)
2019-10-24 06:13 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.85 MB, application/zip)
2019-10-24 13:25 PDT, EWS Watchlist 		no flags Details
Patch for landing (47.86 KB, patch)
2019-10-25 01:24 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2019-10-23 10:19:21 PDT 
It's unfortunate that we currently need to disable things like BigInt and coalesce-expression in test262/config.yaml.

Really what we'd like is have test262-runner know which flag should be passed to JSC in order to run such upcoming-feature tests.
Comment 1 Ross Kirsling 2019-10-24 06:13:11 PDT 
Created attachment 381802 [details]
Patch
Comment 2 Ross Kirsling 2019-10-24 06:15:05 PDT 
Comment on attachment 381802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381802&action=review

> JSTests/test262/expectations.yaml:3422
> +test/language/statements/for-in/dstr/array-elem-nested-memberexpr-optchain-prop-ref.js:

Note: All these for-in/for-of tests are for optional chaining, but they appear to be bogus.
I've reported it here: https://github.com/tc39/test262/pull/2270#issuecomment-545880743
Comment 3 EWS Watchlist 2019-10-24 13:25:52 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2019-10-24 13:25:54 PDT Comment hidden (obsolete)
Comment 5 Keith Miller 2019-10-24 13:57:17 PDT 
Comment on attachment 381802 [details]
Patch

r=me.
Comment 6 Keith Miller 2019-10-24 13:57:31 PDT 
Thanks for doing this. Very helpful!
Comment 7 Ross Kirsling 2019-10-25 01:24:34 PDT 
Created attachment 381895 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-10-25 03:09:42 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2019-10-25 03:09:43 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]:

The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2019-10-25 04:00:45 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]:

imported/w3c/web-platform-tests/content-security-policy/navigate-to/href-location-allowed.html bug 203405 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2019-10-25 04:00:51 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2019-10-25 05:09:13 PDT 
Comment on attachment 381895 [details]
Patch for landing

Clearing flags on attachment: 381895

Committed r251588: <https://trac.webkit.org/changeset/251588>
Comment 13 WebKit Commit Bot 2019-10-25 05:09:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2019-10-25 05:10:16 PDT 
<rdar://problem/56615193>