Bug 203300 - Web Inspector: add ITML debuggable/target type
Summary: Web Inspector: add ITML debuggable/target type
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 200384 203197
Blocks: 201150
  Show dependency treegraph
 
Reported: 2019-10-23 10:11 PDT by Devin Rousso
Modified: 2019-11-09 01:03 PST (History)
11 users (show)

See Also:


Attachments
[Patch] WIP (84.57 KB, patch)
2019-10-23 13:08 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (669.68 KB, patch)
2019-11-09 01:03 PST, Devin Rousso
drousso: review?
drousso: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-10-23 10:11:29 PDT
This will allow the frontend to do distinguish between a regular `JSContext` and an ITML one, as well as knowing at launch what domains/commands/events will be supported by ITML, most of which are not normally supported by `JSContext`, which would also allow us to remove the "extra domains" concept.
Comment 1 Radar WebKit Bug Importer 2019-10-23 11:07:33 PDT
<rdar://problem/56545896>
Comment 2 Devin Rousso 2019-10-23 13:08:27 PDT
Created attachment 381716 [details]
[Patch] WIP
Comment 3 Build Bot 2019-10-23 13:09:06 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 4 Devin Rousso 2019-11-09 01:03:19 PST
Created attachment 383208 [details]
Patch