Bug 201150 - Web Inspector: remove "extra domains" concept now that domains can be added based on the debuggable type
Summary: Web Inspector: remove "extra domains" concept now that domains can be added b...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 200384 203300
Blocks: 213632
  Show dependency treegraph
 
Reported: 2019-08-26 14:05 PDT by Devin Rousso
Modified: 2020-06-25 17:42 PDT (History)
11 users (show)

See Also:


Attachments
Patch (27.43 KB, patch)
2020-06-25 17:38 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (40.21 KB, patch)
2020-06-25 17:42 PDT, Devin Rousso
drousso: review?
drousso: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-26 14:05:26 PDT
.
Comment 1 Radar WebKit Bug Importer 2019-10-23 11:07:56 PDT
<rdar://problem/56545911>
Comment 2 Devin Rousso 2020-05-22 15:42:53 PDT
We also should introduce an `InspectorBackend.finalize()` (or something like that) so that `InspectorBackend` can release the domains/commands/events that aren't actually being used.

It might be worth adding `targetTypes` support to types too.
Comment 3 Devin Rousso 2020-06-25 17:38:34 PDT
Created attachment 402833 [details]
Patch
Comment 4 EWS Watchlist 2020-06-25 17:39:12 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 5 Devin Rousso 2020-06-25 17:42:11 PDT
Created attachment 402834 [details]
Patch

oops, forgot to rebase the inspector protocl tests