Bug 203299 – WKWebView: Username/Password autocomplete does not prompt on non-password inputs in Shadow DOM

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Liam DeBeasi]

Created attachment 381686 [details]
iOS app reproduction

When tapping into a non-password input in the Shadow DOM (for example, type="email") the "Passwords" autocomplete option does not appear. This bug only happens in WKWebView and does not happen in Safari.


Steps to reproduce:

1. Download the attached .zip, and run the extracted Xcode project on a physical iOS device.
2. Tap "Light DOM Username". Notice that the "Password" autocomplete option appears.
3. Tap "Shadow DOM Username". Notice that the "Password" autocomplete option does not appear.
4. Open the following CodePen in Safari on the iOS device: https://codepen.io/liamdebeasi/pen/ZEEeRPo (This is the example that is loaded in the WKWebView app)
5. Tap "Light DOM Username". Notice that the "Password" autocomplete option appears.
6. Tap "Shadow DOM Username". Notice that the "Password" autocomplete option appears.


Expected Results: 

I would expect that the "Passwords" autocomplete option appears for username/password inputs regardless of whether or not the input is in the Shadow DOM.

[Radar WebKit Bug Importer]

<rdar://problem/56544687>

[Daniel Ehrhardt]

More and more HTML Apps go to the App Store. Could someone please take a look into this Issue?

[Calvin Ho]

any update on this bug? Thanks..

[Ryosuke Niwa]

I think the bug is somewhere in AutofillElements. Interesting, this code also uses FocusController::previousFocusableElement/nextFocusableElement so it might be a duplicate of the bug 203292.

[Daniel]

Apple, please don't trivialize this. It really affects our users' experience when moving from web to the app experience.

[Ryosuke Niwa]

(In reply to Daniel from comment #5)
> Apple, please don't trivialize this. It really affects our users' experience
> when moving from web to the app experience.

Could you confirm that what you're experiencing is an issue with autofill within WKWebView in a third party app, and not about autofill in Safari?

[Daniel]

(In reply to Ryosuke Niwa from comment #6)
> Could you confirm that what you're experiencing is an issue with autofill
> within WKWebView in a third party app, and not about autofill in Safari?

Of course, it's about a Cordova app. Relevant dependencies:

- cordova-ios 6.1.1 https://github.com/apache/cordova-ios
- cordova-plugin-ionic-webview 5.0.0 https://github.com/ionic-team/cordova-plugin-ionic-webview

[Liam DeBeasi]

This issue appears to be fixed in iOS 14.5 beta 1. Thank you! (seems like it was the same issue that caused https://bugs.webkit.org/show_bug.cgi?id=203292)

[Ryosuke Niwa]

(In reply to Liam DeBeasi from comment #8)
> This issue appears to be fixed in iOS 14.5 beta 1. Thank you! (seems like it
> was the same issue that caused
> https://bugs.webkit.org/show_bug.cgi?id=203292)

That's a bit surprising. There is definitely code here which needs to be updated.

[Ashley Medway]

I am also seeing this fixed in iOS 14.5 beta 1

[Teodor]

iOS 14.7 Public Beta 3
Issue is still present. Potentially a regression from 14.5 Beta 1.

[Samuel Sheldon]

I have tried this in iOS 15.1 and this issue is still not fixed. 

This is a critical feature for many developers, is there any way to get an estimate on a fix? Or at the very lease a temporary work around or solution we can use in the mean time?

Any update or assistance you can give will be helpful, thanks!

[Ryosuke Niwa]

Just to be clear, this issue tracks user/password autofill feature in non-Safari WKWebView clients. The issue in Safari is tracked by https://bugs.webkit.org/show_bug.cgi?id=172567.

[Samuel Sheldon]

(In reply to Ryosuke Niwa from comment #13)
> Just to be clear, this issue tracks user/password autofill feature in
> non-Safari WKWebView clients. The issue in Safari is tracked by
> https://bugs.webkit.org/show_bug.cgi?id=172567.

Good morning Ryosuke Niwa,

you are right I was looking for the Safari based WKWebView bug. Thank you for passing it along to me! I will make my comments there

[Brent Fulgham]

This is actually:
<rdar://27205947>

[Ryosuke Niwa]

(In reply to Brent Fulgham from comment #15)
> This is actually:
> <rdar://27205947>

Oh, this is not that! That radar is about Safari. This bug is about autofill feature that exist in WKWebView, not Safari.

[Wolf Walter]

This bug does affect my iOS app build with Ionic, Angular and Capacitor.

[Ryosuke Niwa]

(In reply to Ryosuke Niwa from comment #9)
> (In reply to Liam DeBeasi from comment #8)
> > This issue appears to be fixed in iOS 14.5 beta 1. Thank you! (seems like it
> > was the same issue that caused
> > https://bugs.webkit.org/show_bug.cgi?id=203292)
> 
> That's a bit surprising. There is definitely code here which needs to be
> updated.

Oh, I was misunderstanding this problem. WKWebView's autofill feature is indeed fixed by that code change because we use the same functions to find autofillable elements.

[Ryosuke Niwa]

Pull request: https://github.com/WebKit/WebKit/pull/2037

[Ryosuke Niwa]

Let's add a test case so that this won't regress over time.

[EWS]

Committed 252105@main (1671a015250d): <https://commits.webkit.org/252105@main>

Reviewed commits have been landed. Closing PR #2037 and removing active labels.

[Ryosuke Niwa]

The bug has been fixed in https://commits.webkit.org/r269059.

Autofill not functioning across shadow boundaries in Safari is tracked by the bug 172567.

[Mischa]

Does this fix also solve https://bugs.webkit.org/show_bug.cgi?id=226023

[Ryosuke Niwa]

(In reply to Mischa from comment #23)
> Does this fix also solve https://bugs.webkit.org/show_bug.cgi?id=226023

No.