Bug 203277 - Python 3: Add support in webkitpy.common.checkout.scm
Summary: Python 3: Add support in webkitpy.common.checkout.scm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-22 15:42 PDT by Jonathan Bedard
Modified: 2019-10-25 02:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (34.65 KB, patch)
2019-10-22 15:51 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (35.92 KB, patch)
2019-10-24 16:52 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-10-22 15:42:38 PDT 
All of webkitpy.common.checkout.scm needs to support Python 3.
Comment 1 Jonathan Bedard 2019-10-22 15:51:10 PDT 
Created attachment 381621 [details]
Patch
Comment 2 Jonathan Bedard 2019-10-24 16:52:20 PDT 
Created attachment 381859 [details]
Patch
Comment 3 Stephanie Lewis 2019-10-24 16:59:20 PDT 
Comment on attachment 381859 [details]
Patch

Looks fine for the most part.  I think the slow stuff should be its own patch
Comment 4 Jonathan Bedard 2019-10-24 17:11:19 PDT 
(In reply to Jonathan Bedard from comment #2)
> Created attachment 381859 [details]
> Patch

The slow stuff is a prerequisite to land this, otherwise the SCM tests make the test-webkitpy-python3 script unusably slow. The slow stuff can't really be tested without the SCM stuff, though.
Comment 5 WebKit Commit Bot 2019-10-24 23:52:21 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381859 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2019-10-24 23:52:27 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381859 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-10-25 02:11:39 PDT 
Comment on attachment 381859 [details]
Patch

Clearing flags on attachment: 381859

Committed r251587: <https://trac.webkit.org/changeset/251587>
Comment 8 WebKit Commit Bot 2019-10-25 02:11:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-10-25 02:12:16 PDT 
<rdar://problem/56612397>