Bug 203002 - Standardize "PageID=" vs "pageID =" in release logging
Summary: Standardize "PageID=" vs "pageID =" in release logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-15 13:12 PDT by Simon Fraser (smfr)
Modified: 2019-10-25 01:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (51.31 KB, patch)
2019-10-24 20:46 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-10-15 13:12:17 PDT
It's hard to search logs if the output is sometimes "pageID = 6" and others is "(PageID=6)"
Comment 1 Chris Dumez 2019-10-24 20:46:14 PDT
Created attachment 381871 [details]
Patch
Comment 2 Geoffrey Garen 2019-10-24 21:31:33 PDT
Comment on attachment 381871 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-10-24 22:47:38 PDT
The commit-queue encountered the following flaky tests while processing attachment 381871 [details]:

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2019-10-24 22:47:40 PDT
The commit-queue encountered the following flaky tests while processing attachment 381871 [details]:

The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-10-25 01:14:14 PDT
Comment on attachment 381871 [details]
Patch

Clearing flags on attachment: 381871

Committed r251585: <https://trac.webkit.org/changeset/251585>
Comment 6 WebKit Commit Bot 2019-10-25 01:14:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-25 01:15:16 PDT
<rdar://problem/56611436>