Bug 202934 - Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out
Summary: Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is tim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 143589
Blocks:
  Show dependency tree / graph
 
Reported: 2019-10-14 10:05 PDT by Yury Semikhatsky
Modified: 2019-11-07 12:37 PST (History)
14 users (show)

See Also:

Attachments
Patch (326.80 KB, patch)
2019-11-05 17:17 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (411.85 KB, patch)
2019-11-05 19:26 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (414.19 KB, patch)
2019-11-05 19:28 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2019-10-14 10:05:05 PDT 
Since https://trac.webkit.org/changeset/250087 injected script is not passing the test added for https://webkit.org/b/146141. It is timing out on the array with 1M entries because of changes in the following line:
 
processProperties(o, arrayIndexPropertyNames(o, Math.min(object.length, 100)), isOwnProperty); )
Comment 1 Yury Semikhatsky 2019-10-14 10:05:40 PDT 
Unfortunately the error was masked because the test is marked as flaky :(
Comment 2 Radar WebKit Bug Importer 2019-10-14 17:12:47 PDT 
<rdar://problem/56270900>
Comment 3 Devin Rousso 2019-11-05 17:17:18 PST 
Created attachment 382870 [details]
Patch
Comment 4 Devin Rousso 2019-11-05 19:26:47 PST 
Created attachment 382884 [details]
Patch

Fix WK1 test expectations
Comment 5 Devin Rousso 2019-11-05 19:28:06 PST 
Created attachment 382885 [details]
Patch

Fix WK1 test expectations (this time actually uploading the file)
Comment 6 WebKit Commit Bot 2019-11-07 12:37:06 PST 
Comment on attachment 382885 [details]
Patch

Clearing flags on attachment: 382885

Committed r252202: <https://trac.webkit.org/changeset/252202>
Comment 7 WebKit Commit Bot 2019-11-07 12:37:07 PST 
All reviewed patches have been landed.  Closing bug.