Bug 146141 - Web Inspector: Avoid getOwnPropertyNames/Symbols on very large lists
Summary: Web Inspector: Avoid getOwnPropertyNames/Symbols on very large lists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-18 22:49 PDT by Joseph Pecoraro
Modified: 2015-06-19 01:06 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (14.94 KB, patch)
2015-06-18 22:57 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-06-18 22:49:44 PDT
* SUMMARY
Avoid getOwnPropertyNames/Symbols on very large lists.

Note that better handling of large lists in general should be handled by:
<https://webkit.org/b/143589> Web Inspector: Better handling for large collections in Object Trees

For now, lets not hang / out of memory trying to build a list of all the property names in a multi-million element list.

* STEPS TO REPRODUCE
1. js> var buffer = new ArrayBuffer(10000000); var int8View = new Int8Array(buffer); int8View
  => hang (Web Content Process's memory grows, attempting to get property names for a preview)
2. js> var buffer = new ArrayBuffer(10000000); var int8View = new Int8Array(buffer);
3. Type: "int8View."
  => hang (Web Content Process's memory grows, attempting to get property names for autocompletion)
Comment 1 Joseph Pecoraro 2015-06-18 22:56:55 PDT
<rdar://problem/21233251>
Comment 2 Joseph Pecoraro 2015-06-18 22:57:48 PDT
Created attachment 255175 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-06-19 01:06:37 PDT
Comment on attachment 255175 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 255175

Committed r185741: <http://trac.webkit.org/changeset/185741>
Comment 4 WebKit Commit Bot 2015-06-19 01:06:42 PDT
All reviewed patches have been landed.  Closing bug.