Bug 202900 – Chromium test-case asserts with ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Emilio Cobos Álvarez (:emilio)]

On master (247b0314320d499ae788b6ea993aa1d98e2d607e / r250962), WebKitGTK build.

Running this test-case: https://cs.chromium.org/chromium/src/third_party/blink/web_tests/editing/execCommand/listify-output-crash.html?rcl=753caf715d8f30f0c673f1b4b36dadfc75c3201f

Asserts like:

ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)
../../Source/WebCore/editing/CompositeEditCommand.cpp(1407) : void WebCore::CompositeEditCommand::moveParagraph(const WebCore::VisiblePosition&, const WebCore::VisiblePosition&, const WebCore::VisiblePosition&, bool, bool)
1   0x7f5f716373d3 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x9) [0x7f5f716373d3]
2   0x7f5f7d2e05f2 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3WTF15CrashOnOverflow10overflowedEv+0) [0x7f5f7d2e05f2]
3   0x7f5f80ec93b1 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore20CompositeEditCommand13moveParagraphERKNS_15VisiblePositionES3_S3_bb+0x67) [0x7f5f80ec93b1]
4   0x7f5f7f8cfe45 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17InsertListCommand16listifyParagraphERKNS_15VisiblePositionERKNS_13QualifiedNameE+0x8ff) [0x7f5f7f8cfe45]
5   0x7f5f7f8ceb35 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17InsertListCommand25doApplyForSingleParagraphEbRKNS_17HTMLQualifiedNameEPNS_5RangeE+0x91d) [0x7f5f7f8ceb35]
6   0x7f5f7f8ce1a0 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17InsertListCommand7doApplyEv+0x8e8) [0x7f5f7f8ce1a0]
7   0x7f5f80ec3cd3 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore20CompositeEditCommand5applyEv+0xf5) [0x7f5f80ec3cd3]
8   0x7f5f7f8a7dc7 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xcba2dc7) [0x7f5f7f8a7dc7]
9   0x7f5f7f8ab62a /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK7WebCore6Editor7Command7executeERKN3WTF6StringEPNS_5EventE+0xdc) [0x7f5f7f8ab62a]
10  0x7f5f7f696268 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore8Document11execCommandERKN3WTF6StringEbS4_+0x56) [0x7f5f7f696268]
11  0x7f5f7e3a4694 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb69f694) [0x7f5f7e3a4694]
12  0x7f5f7e3be1b6 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6b91b6) [0x7f5f7e3be1b6]
13  0x7f5f7e3a4702 /home/emilio/src/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore38jsDocumentPrototypeFunctionExecCommandEPN3JSC14JSGlobalObjectEPNS0_9CallFrameE+0x23) [0x7f5f7e3a4702]
14  0x7f5f1bbfa16b [0x7f5f1bbfa16b]

[Emilio Cobos Álvarez (:emilio)]

This test-case also reproduces the same issue: https://cs.chromium.org/chromium/src/third_party/blink/web_tests/editing/execCommand/outdent-collapse-table-crash-2.html?rcl=753caf715d8f30f0c673f1b4b36dadfc75c3201f

[Radar WebKit Bug Importer]

<rdar://problem/56271301>

[Ahmad Saleem]

Fixed in this commit - https://chromium.googlesource.com/chromium/blink/+/0db0330bd68079a479c9db4e22565742c5b30699

& Changes are here: https://searchfox.org/wubkat/source/Source/WebCore/editing/InsertListCommand.cpp#428

Will do PR to fix it.

[EWS]

Committed 258416@main (97d658482be2): <https://commits.webkit.org/258416@main>

Reviewed commits have been landed. Closing PR #8152 and removing active labels.