Bug 202876 - requestIdleCallback cannot be enabled in DumpRenderTree on Windows
Summary: requestIdleCallback cannot be enabled in DumpRenderTree on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-11 20:38 PDT by Ryosuke Niwa
Modified: 2019-10-15 14:49 PDT (History)
7 users (show)

See Also:

Attachments
Fixes DRT on Windows (6.33 KB, patch)
2019-10-11 20:40 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed a typo. (6.33 KB, patch)
2019-10-11 22:46 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-10-11 20:38:06 PDT 
requestIdleCallback is not enabled in DumpRenderTree on Windows
Comment 1 Ryosuke Niwa 2019-10-11 20:40:05 PDT 
Created attachment 380814 [details]
Fixes DRT on Windows
Comment 2 Wenson Hsieh 2019-10-11 21:31:19 PDT 
Comment on attachment 380814 [details]
Fixes DRT on Windows

View in context: https://bugs.webkit.org/attachment.cgi?id=380814&action=review

r=mews

> Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h:215
> +#define WebKitRequestIdleCallbackEnabledPreferenceKey "RequestIdleCallbackEnabled"

Nit - it seems most of the other strings defined in this file are “WebKit*”. Should this match that convention?
Comment 3 Ryosuke Niwa 2019-10-11 22:46:38 PDT 
Created attachment 380819 [details]
Fixed a typo.
Comment 4 Ryosuke Niwa 2019-10-11 22:49:40 PDT 
Comment on attachment 380819 [details]
Fixed a typo.

Wait for Windows EWS.
Comment 5 Ryosuke Niwa 2019-10-12 02:16:41 PDT 
Comment on attachment 380819 [details]
Fixed a typo.

Clearing flags on attachment: 380819

Committed r251046: <https://trac.webkit.org/changeset/251046>
Comment 6 Ryosuke Niwa 2019-10-12 02:16:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Ryosuke Niwa 2019-10-12 02:19:30 PDT 
Committed r251047: <https://trac.webkit.org/changeset/251047>
Comment 8 Ling Ho 2019-10-15 14:49:24 PDT 
<rdar://problem/56216449>