Invoke these callbacks at all.
Created attachment 380687 [details] Adds more scaffolding
Created attachment 380715 [details] Add the forgotten file
Comment on attachment 380715 [details] Add the forgotten file View in context: https://bugs.webkit.org/attachment.cgi?id=380715&action=review > LayoutTests/requestidlecallback/requestidlecallback-is-called-expected.txt:8 > +PASS logs.join(", ") is "1.A1, 2.B1, 4.A2, 3.B2" This ordering is expected in accordance with the specification although this is not what Chrome does. See https://github.com/w3c/requestidlecallback/issues/82
<rdar://problem/56178321>
Comment on attachment 380715 [details] Add the forgotten file Attachment 380715 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13119724 New failing tests: requestidlecallback/requestidlecallback-is-not-called-when-canceled.html requestidlecallback/requestidlecallback-is-called.html
Created attachment 380738 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Oh, looks like I had failed to enable requestIdleCallback on Windows. That's an orthogonal issue to this patch though. And WK1's test failure seems to be unrelated to this patch.
Comment on attachment 380715 [details] Add the forgotten file View in context: https://bugs.webkit.org/attachment.cgi?id=380715&action=review > Source/WebCore/dom/IdleCallbackController.cpp:88 > + auto deadline = now + 50_ms; Where does that 50ms come from?
Committed r251050: <https://trac.webkit.org/changeset/251050>