Bug 202864 - [ews] Services EWS should also run build.webkit.org unit tests
Summary: [ews] Services EWS should also run build.webkit.org unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-11 13:42 PDT by Aakash Jain
Modified: 2019-10-12 08:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.71 KB, patch)
2019-10-11 13:52 PDT, Aakash Jain 		jbedard: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-10-11 13:42:07 PDT 
Services EWS should also run build.webkit.org unit tests.
Comment 1 Aakash Jain 2019-10-11 13:52:45 PDT 
Created attachment 380782 [details]
Patch
Comment 2 Aakash Jain 2019-10-11 13:53:18 PDT 
tested locally.
Comment 3 Jonathan Bedard 2019-10-11 14:09:48 PDT 
Comment on attachment 380782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380782&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:607
> +class RunBuildWebKitUnitTests(shell.ShellCommand):

Maybe should be RunBuildWebKitOrgUnitTests since we actually have a build-webkit script.
Comment 4 Aakash Jain 2019-10-11 14:25:47 PDT 
> Maybe should be RunBuildWebKitOrgUnitTests since we actually have a build-webkit script.
Sure, will change it to RunBuildWebKitOrgUnitTests.
Comment 5 Aakash Jain 2019-10-11 14:26:50 PDT 
Committed r251025: <https://trac.webkit.org/changeset/251025>
Comment 6 Radar WebKit Bug Importer 2019-10-12 08:21:43 PDT 
<rdar://problem/56219593>