RESOLVED FIXED 202864
[ews] Services EWS should also run build.webkit.org unit tests 
https://bugs.webkit.org/show_bug.cgi?id=202864
Summary [ews] Services EWS should also run build.webkit.org unit tests
Aakash Jain
Reported 2019-10-11 13:42:07 PDT
Services EWS should also run build.webkit.org unit tests.
Attachments
Patch (6.71 KB, patch)
2019-10-11 13:52 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-10-11 13:52:45 PDT
Created attachment 380782 [details] Patch
Aakash Jain
Comment 2 2019-10-11 13:53:18 PDT
tested locally.
Jonathan Bedard
Comment 3 2019-10-11 14:09:48 PDT
Comment on attachment 380782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380782&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:607 > +class RunBuildWebKitUnitTests(shell.ShellCommand): Maybe should be RunBuildWebKitOrgUnitTests since we actually have a build-webkit script.
Aakash Jain
Comment 4 2019-10-11 14:25:47 PDT
> Maybe should be RunBuildWebKitOrgUnitTests since we actually have a build-webkit script. Sure, will change it to RunBuildWebKitOrgUnitTests.
Aakash Jain
Comment 5 2019-10-11 14:26:50 PDT
Committed r251025: <https://trac.webkit.org/changeset/251025>
Radar WebKit Bug Importer
Comment 6 2019-10-12 08:21:43 PDT
<rdar://problem/56219593>
Note You need to log in before you can comment on or make changes to this bug.