Add an EWS to run ews unit-tests. This would be to catch any issues in Buildbot configurations.
Created attachment 374581 [details] Patch
Attachment 374581 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:430: [TestRunEWSBuildbotCheckConfig.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:430: [TestRunEWSBuildbotCheckConfig.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:444: [TestRunEWSBuildbotCheckConfig.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:444: [TestRunEWSBuildbotCheckConfig.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:466: [TestRunEWSUnitTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:466: [TestRunEWSUnitTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:480: [TestRunEWSUnitTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:480: [TestRunEWSUnitTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:582: [RunEWSUnitTests.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:586: [RunEWSUnitTests.getResultSummary] Instance of 'RunEWSUnitTests' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:596: [RunEWSBuildbotCheckConfig.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:600: [RunEWSBuildbotCheckConfig.getResultSummary] Instance of 'RunEWSBuildbotCheckConfig' has no 'results' member [pylint/E1101] [5] Total errors found: 12 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 374582 [details] Patch
Attachment 374582 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:430: [TestRunEWSBuildbotCheckConfig.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:430: [TestRunEWSBuildbotCheckConfig.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:444: [TestRunEWSBuildbotCheckConfig.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:444: [TestRunEWSBuildbotCheckConfig.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:466: [TestRunEWSUnitTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:466: [TestRunEWSUnitTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:480: [TestRunEWSUnitTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:480: [TestRunEWSUnitTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:582: [RunEWSUnitTests.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:586: [RunEWSUnitTests.getResultSummary] Instance of 'RunEWSUnitTests' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:596: [RunEWSBuildbotCheckConfig.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:600: [RunEWSBuildbotCheckConfig.getResultSummary] Instance of 'RunEWSBuildbotCheckConfig' has no 'results' member [pylint/E1101] [5] Total errors found: 12 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sample runs: Success: https://ews-build.webkit-uat.org/#/builders/41/builds/9 Failure: https://ews-build.webkit-uat.org/#/builders/41/builds/6 Skip: https://ews-build.webkit-uat.org/#/builders/41/builds/7
Comment on attachment 374582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374582&action=review > Tools/BuildSlaveSupport/ews-build/config.json:445 > + "shortname": "tools", Not sure if that's the best name for the status-bubble for this EWS.
Comment on attachment 374582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374582&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:43 > + 'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'tools'] Do we intend this form of EWS to include more than just EWS tests? If that's the case, I'd call it 'services'. We could include build.webkit.org tests and resultsdbpy tests too (off the top of my head, these would be the most useful to me personally). >> Tools/BuildSlaveSupport/ews-build/config.json:445 >> + "shortname": "tools", > > Not sure if that's the best name for the status-bubble for this EWS. If we intend this bubble to cover more than just EWS, I think it should be 'services'. Otherwise, I actually thing it should be either 'ews' or 'buildbot-ews'.
Comment on attachment 374582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374582&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:43 >> + 'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'tools'] > > Do we intend this form of EWS to include more than just EWS tests? If that's the case, I'd call it 'services'. We could include build.webkit.org tests and resultsdbpy tests too (off the top of my head, these would be the most useful to me personally). Yeah, we should include more tests in this queue. Especially because we already have too many status-bubbles to display in Bugzilla, and would prefer to limit them when possible. I'll rename it to 'services'. Will add build-step for build.webkit.org tests in subsequent patch. Please let me know about how to run resultsdbpy tests. A minor efficiency concern might be there with CheckPatchRelevance step, if a patch is relevant to only one kind of test, we will still run multiple tests on the queue. Which might be fine given that these test are fast anyways. If that actually becomes a concern, we can fix it using doStepIf for the individual tests.
Created attachment 374604 [details] Patch
Attachment 374604 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:430: [TestRunEWSBuildbotCheckConfig.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:430: [TestRunEWSBuildbotCheckConfig.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:444: [TestRunEWSBuildbotCheckConfig.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:444: [TestRunEWSBuildbotCheckConfig.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:466: [TestRunEWSUnitTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:466: [TestRunEWSUnitTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:480: [TestRunEWSUnitTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:480: [TestRunEWSUnitTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:582: [RunEWSUnitTests.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:586: [RunEWSUnitTests.getResultSummary] Instance of 'RunEWSUnitTests' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:596: [RunEWSBuildbotCheckConfig.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:600: [RunEWSBuildbotCheckConfig.getResultSummary] Instance of 'RunEWSBuildbotCheckConfig' has no 'results' member [pylint/E1101] [5] Total errors found: 12 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Aakash Jain from comment #8) > Comment on attachment 374582 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374582&action=review > > >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:43 > >> + 'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'tools'] > > > > Do we intend this form of EWS to include more than just EWS tests? If that's the case, I'd call it 'services'. We could include build.webkit.org tests and resultsdbpy tests too (off the top of my head, these would be the most useful to me personally). > > Yeah, we should include more tests in this queue. Especially because we > already have too many status-bubbles to display in Bugzilla, and would > prefer to limit them when possible. I'll rename it to 'services'. Will add > build-step for build.webkit.org tests in subsequent patch. Please let me > know about how to run resultsdbpy tests. > > A minor efficiency concern might be there with CheckPatchRelevance step, if > a patch is relevant to only one kind of test, we will still run multiple > tests on the queue. Which might be fine given that these test are fast > anyways. If that actually becomes a concern, we can fix it using doStepIf > for the individual tests. That efficiency trade-off seems fine. Service tests tend to be fast, and we won't be running these on most patches anyways.
Sample runs: Failure: https://ews-build.webkit-uat.org/#/builders/42/builds/5 Skip: https://ews-build.webkit-uat.org/#/builders/42/builds/1
Created attachment 374613 [details] Patch
Comment on attachment 374613 [details] Patch Clearing flags on attachment: 374613 Committed r247694: <https://trac.webkit.org/changeset/247694>
All reviewed patches have been landed. Closing bug.
<rdar://problem/53410028>