NEW202756
[GTK][GStreamer][Picture-in-Picture Web API] Add platform support for PiP 
https://bugs.webkit.org/show_bug.cgi?id=202756
Summary [GTK][GStreamer][Picture-in-Picture Web API] Add platform support for PiP
Carlos Bentzen
Reported 2019-10-09 10:08:14 PDT
The PiP Web API is in development in bug 182688. It is currently relying on the webkitSetPresentationMode() API for Cocoa backends, but support for it could be added for the GStreamer backend. Do the WebKitGTK developers welcome this feature?
Attachments
Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-10-09 10:23:33 PDT
Hey Carlos! Yeah it would be great to have this supported. The pipeline's video-sink bin would probably need an output-selector with 2 downstream branches, one for the existing video sink and one that would, maybe?, render to a separate GTK window? Would you work on this?
Carlos Bentzen
Comment 2 2019-10-09 10:54:36 PDT
(In reply to Philippe Normand from comment #1) > Hey Carlos! > > Yeah it would be great to have this supported. Great to hear! :) > The pipeline's video-sink bin would probably need an output-selector with 2 downstream branches, one for > the existing video sink and one that would, maybe?, render to a separate GTK > window? Seems like a plan. Most browser implementations only allow the creation of one PIP window, because of platform limitations (https://w3c.github.io/picture-in-picture/#one-pip-window)... Is that desirable for WebKitGTK too? I'm wondering that because, if so, the GTK window creation maybe would need to be in the UIProcess? So in this case we'd need to figure out a path for zero-copy (if that is possible)? Just some early thoughts. I might be totally wrong there. > > Would you work on this? Yeah. I intend to start experimenting on it soon :)
Xabier Rodríguez Calvar
Comment 3 2019-10-10 01:00:54 PDT
(In reply to Carlos Eduardo Ramalho from comment #2) > Most browser implementations only allow the creation of one PIP window, > because of platform limitations > (https://w3c.github.io/picture-in-picture/#one-pip-window)... Is that > desirable for WebKitGTK too? > > I'm wondering that because, if so, the GTK window creation maybe would need > to be in the UIProcess? So in this case we'd need to figure out a path for > zero-copy (if that is possible)? > > Just some early thoughts. I might be totally wrong there. Zan and Miguel can have some good thoughts about rendering arch.
Philippe Normand
Comment 4 2020-03-11 07:22:51 PDT
(In reply to Carlos Eduardo Ramalho from comment #2) > > Would you work on this? > > Yeah. I intend to start experimenting on it soon :) Have you managed to get started?
Carlos Bentzen
Comment 5 2020-03-11 07:37:08 PDT
(In reply to Philippe Normand from comment #4) > (In reply to Carlos Eduardo Ramalho from comment #2) > > > > Would you work on this? > > > > Yeah. I intend to start experimenting on it soon :) > > Have you managed to get started? No. Do you want to take over?
Philippe Normand
Comment 6 2020-03-11 07:43:27 PDT
My list is too big currently. I'll ping here again if/when I manage to shrink it a bit :)
Philippe Normand
Comment 7 2020-05-20 07:41:34 PDT
*** Bug 211569 has been marked as a duplicate of this bug. ***
Philippe Normand
Comment 8 2020-11-15 07:16:01 PST
I've started some work on this.
Note You need to log in before you can comment on or make changes to this bug.