Bug 202627 - [iOS] Unmuting capture of a page is not working
Summary: [iOS] Unmuting capture of a page is not working
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 202630
  Show dependency tree / graph
 
Reported: 2019-10-07 02:59 PDT by youenn fablet
Modified: 2019-10-07 07:36 PDT (History)
14 users (show)

See Also:

Attachments
Patch (16.36 KB, patch)
2019-10-07 03:09 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.35 KB, patch)
2019-10-07 05:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (16.42 KB, patch)
2019-10-07 06:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-10-07 02:59:28 PDT 
[iOS] Unmuting capture of a page is not working
Comment 1 youenn fablet 2019-10-07 03:09:35 PDT 
Created attachment 380311 [details]
Patch
Comment 2 youenn fablet 2019-10-07 03:20:15 PDT 
<rdar://problem/55970691>
Comment 3 youenn fablet 2019-10-07 05:50:43 PDT 
Created attachment 380317 [details]
Patch
Comment 4 Eric Carlson 2019-10-07 06:07:47 PDT 
Comment on attachment 380317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380317&action=review

> Source/WebCore/ChangeLog:8
> +        Before the patch, we were muting the captur tracks but never unmuting them.

s/captur/capture/

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:479
> +void MediaStreamTrack::updateCaptureAccordingMutedState(Document& document)

Nit: updateCaptureAccordingToMutedState would be slightly clearer.
Comment 5 youenn fablet 2019-10-07 06:49:10 PDT 
Created attachment 380322 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-10-07 07:36:24 PDT 
Comment on attachment 380322 [details]
Patch for landing

Clearing flags on attachment: 380322

Committed r250774: <https://trac.webkit.org/changeset/250774>
Comment 7 WebKit Commit Bot 2019-10-07 07:36:26 PDT 
All reviewed patches have been landed.  Closing bug.