Bug 202521 - http/tests/security/navigate-when-restoring-cached-page.html should not use RTCPeerConnection to not enter in page cache
Summary: http/tests/security/navigate-when-restoring-cached-page.html should not use R...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 202403
  Show dependency tree / graph
 
Reported: 2019-10-03 06:09 PDT by youenn fablet
Modified: 2019-10-03 11:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2019-10-03 06:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (6.78 KB, patch)
2019-10-03 09:24 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-10-03 06:09:11 PDT 
http/tests/security/navigate-when-restoring-cached-page.html should not use RTCPeerConnection to not enter in page cache
Comment 1 youenn fablet 2019-10-03 06:15:26 PDT 
Created attachment 380106 [details]
Patch
Comment 2 Chris Dumez 2019-10-03 08:28:41 PDT 
Comment on attachment 380106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380106&action=review

r=me with comments.

> Source/WebCore/testing/Internals.cpp:931
> +class CannotSuspendActiveDOMObject final : public ActiveDOMObject, public RefCounted<CannotSuspendActiveDOMObject> {

CannotSuspendActiveDOMObject -> UnsuspendableActiveDOMObject

> Source/WebCore/testing/Internals.h:906
> +    RefPtr<CannotSuspendActiveDOMObject> m_cannotSuspendActiveDOMObject;

m_unsuspendableActiveDOMObject.
Comment 3 youenn fablet 2019-10-03 09:24:51 PDT 
Created attachment 380123 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-10-03 11:07:32 PDT 
Comment on attachment 380123 [details]
Patch for landing

Clearing flags on attachment: 380123

Committed r250662: <https://trac.webkit.org/changeset/250662>
Comment 5 WebKit Commit Bot 2019-10-03 11:07:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-03 11:08:16 PDT 
<rdar://problem/55953366>