Bug 202403 - Allow to suspend RTCPeerConnection when not connected
Summary: Allow to suspend RTCPeerConnection when not connected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 202395 202396 202400 202521
Blocks: 202293
  Show dependency tree / graph
 
Reported: 2019-10-01 06:54 PDT by youenn fablet
Modified: 2019-10-04 09:31 PDT (History)
14 users (show)

See Also:

Attachments
Patch (31.16 KB, patch)
2019-10-01 06:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (38.75 KB, patch)
2019-10-03 01:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (38.75 KB, patch)
2019-10-03 06:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-10-01 06:54:22 PDT 
Allow to suspend RTCPeerConnection when not connected
Comment 1 youenn fablet 2019-10-01 06:58:02 PDT 
Created attachment 379901 [details]
Patch
Comment 2 youenn fablet 2019-10-03 01:19:54 PDT 
Created attachment 380087 [details]
Patch
Comment 3 youenn fablet 2019-10-03 06:08:46 PDT 
Created attachment 380104 [details]
Patch
Comment 4 Chris Dumez 2019-10-04 08:28:18 PDT 
Comment on attachment 380104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380104&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:502
> +    // FIXME: Evaluate whether to extend this to connected cases as well.

Once this lands, I'll try it out on top sites and let you know if this did the trick or not.
Comment 5 WebKit Commit Bot 2019-10-04 09:30:25 PDT 
Comment on attachment 380104 [details]
Patch

Clearing flags on attachment: 380104

Committed r250726: <https://trac.webkit.org/changeset/250726>
Comment 6 WebKit Commit Bot 2019-10-04 09:30:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-04 09:31:20 PDT 
<rdar://problem/55985113>