WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
20243
Potential crash with RenderLayer clipRects
https://bugs.webkit.org/show_bug.cgi?id=20243
Summary
Potential crash with RenderLayer clipRects
Simon Fraser (smfr)
Reported
2008-07-31 11:14:03 PDT
Bug 20066
changed RenderLayer::calculateClipRects() to not call parent()->calculateClipRects() in some situations. That means that the parent's clipRects are no longer guaranteed to be set up, so the code lower in the method needs to protect against this.
Attachments
Patch
(1.35 KB, patch)
2008-07-31 11:22 PDT
,
Simon Fraser (smfr)
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2008-07-31 11:20:25 PDT
I haven't been able to actually crash, but here's a null-check patch.
Simon Fraser (smfr)
Comment 2
2008-07-31 11:22:20 PDT
Created
attachment 22580
[details]
Patch
Dave Hyatt
Comment 3
2008-07-31 13:09:30 PDT
Comment on
attachment 22580
[details]
Patch r=me
Simon Fraser (smfr)
Comment 4
2008-07-31 14:11:18 PDT
Committed
r35496
M WebCore/rendering/RenderLayer.cpp M WebCore/ChangeLog
r35496
= aec6a3acb56598eac0ab03de1d44cb8679883d72 (trunk)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug