Bug 20243 - Potential crash with RenderLayer clipRects
Summary: Potential crash with RenderLayer clipRects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-31 11:14 PDT by Simon Fraser (smfr)
Modified: 2008-07-31 14:11 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2008-07-31 11:22 PDT, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-07-31 11:14:03 PDT
Bug 20066 changed RenderLayer::calculateClipRects() to not call parent()->calculateClipRects() in some situations. That means that the parent's clipRects are no longer guaranteed to be set up, so the code lower in the method needs to protect against this.
Comment 1 Simon Fraser (smfr) 2008-07-31 11:20:25 PDT
I haven't been able to actually crash, but here's a null-check patch.
Comment 2 Simon Fraser (smfr) 2008-07-31 11:22:20 PDT
Created attachment 22580 [details]
Patch
Comment 3 Dave Hyatt 2008-07-31 13:09:30 PDT
Comment on attachment 22580 [details]
Patch

r=me
Comment 4 Simon Fraser (smfr) 2008-07-31 14:11:18 PDT
Committed r35496
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/ChangeLog
r35496 = aec6a3acb56598eac0ab03de1d44cb8679883d72 (trunk)