Bug 202315 – Move legacy custom protocol registration from process pool to NetworkProcessProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Move legacy custom protocol registration from process pool to NetworkProcessProxy

[Alex Christensen]

Created attachment 379732 [details]
Patch

[Alex Christensen]

Created attachment 379735 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Alex Christensen]

GTK API maintainers: Please deprecate webkit_web_context_register_uri_scheme and replace it with something shaped more like WKURLSchemeHandler.

[Tim Horton]

Comment on attachment 379735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379735&action=review

> Source/WebKit/ChangeLog:15
> +

words

> Source/WebKit/UIProcess/WebProcessPool.cpp:1527
> +            processPool->ensureNetworkProcess().unregisterSchemeForLegacyCustomProtocol(urlScheme);

Why is the structure of these different? Ensure to unregister but not register?

[Alex Christensen]

http://trac.webkit.org/r250457

[Radar WebKit Bug Importer]

<rdar://problem/55793772>

[Carlos Garcia Campos]

(In reply to Alex Christensen from comment #4)
> GTK API maintainers: Please deprecate webkit_web_context_register_uri_scheme
> and replace it with something shaped more like WKURLSchemeHandler.

hmm, that needs to be registered per web view? Good thing seems to be that we never go to the network process for custom protocols, right?

[Carlos Garcia Campos]

(In reply to Carlos Garcia Campos from comment #8)
> (In reply to Alex Christensen from comment #4)
> > GTK API maintainers: Please deprecate webkit_web_context_register_uri_scheme
> > and replace it with something shaped more like WKURLSchemeHandler.
> 
> hmm, that needs to be registered per web view? Good thing seems to be that
> we never go to the network process for custom protocols, right?

https://bugs.webkit.org/show_bug.cgi?id=202407