Bug 202315 - Move legacy custom protocol registration from process pool to NetworkProcessProxy
Summary: Move legacy custom protocol registration from process pool to NetworkProcessP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-27 09:24 PDT by Alex Christensen
Modified: 2019-10-01 08:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.05 KB, patch)
2019-09-27 09:28 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2019-09-27 09:57 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-27 09:24:29 PDT 
Move legacy custom protocol registration from process pool to NetworkProcessProxy
Comment 1 Alex Christensen 2019-09-27 09:28:02 PDT 
Created attachment 379732 [details]
Patch
Comment 2 Alex Christensen 2019-09-27 09:57:29 PDT 
Created attachment 379735 [details]
Patch
Comment 3 EWS Watchlist 2019-09-27 09:58:14 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Alex Christensen 2019-09-27 09:59:59 PDT 
GTK API maintainers: Please deprecate webkit_web_context_register_uri_scheme and replace it with something shaped more like WKURLSchemeHandler.
Comment 5 Tim Horton 2019-09-27 13:13:29 PDT 
Comment on attachment 379735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379735&action=review

> Source/WebKit/ChangeLog:15
> +

words

> Source/WebKit/UIProcess/WebProcessPool.cpp:1527
> +            processPool->ensureNetworkProcess().unregisterSchemeForLegacyCustomProtocol(urlScheme);

Why is the structure of these different? Ensure to unregister but not register?
Comment 6 Alex Christensen 2019-09-27 13:56:12 PDT 
http://trac.webkit.org/r250457
Comment 7 Radar WebKit Bug Importer 2019-09-27 13:57:24 PDT 
<rdar://problem/55793772>
Comment 8 Carlos Garcia Campos 2019-09-30 05:31:57 PDT 
(In reply to Alex Christensen from comment #4)
> GTK API maintainers: Please deprecate webkit_web_context_register_uri_scheme
> and replace it with something shaped more like WKURLSchemeHandler.

hmm, that needs to be registered per web view? Good thing seems to be that we never go to the network process for custom protocols, right?
Comment 9 Carlos Garcia Campos 2019-10-01 08:48:47 PDT 
(In reply to Carlos Garcia Campos from comment #8)
> (In reply to Alex Christensen from comment #4)
> > GTK API maintainers: Please deprecate webkit_web_context_register_uri_scheme
> > and replace it with something shaped more like WKURLSchemeHandler.
> 
> hmm, that needs to be registered per web view? Good thing seems to be that
> we never go to the network process for custom protocols, right?

https://bugs.webkit.org/show_bug.cgi?id=202407