Bug 202407 - [GTK][WPE] Stop using legacy custom protocol implementation
Summary: [GTK][WPE] Stop using legacy custom protocol implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2019-10-01 08:43 PDT by Carlos Garcia Campos
Modified: 2019-10-02 01:00 PDT (History)
10 users (show)

See Also:


Attachments
Patch (67.82 KB, patch)
2019-10-01 08:48 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (63.78 KB, patch)
2019-10-01 09:05 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Fix WPE (63.99 KB, patch)
2019-10-01 09:14 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-10-01 08:43:30 PDT
Use the new approach, which is simpler and doesn't require to go to the network process to load custom protocols.
Comment 1 Carlos Garcia Campos 2019-10-01 08:48:31 PDT
Created attachment 379905 [details]
Patch
Comment 2 EWS Watchlist 2019-10-01 08:49:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2019-10-01 08:57:52 PDT
Oops, I removed the wrong file :-P
Comment 4 Carlos Garcia Campos 2019-10-01 09:05:34 PDT
Created attachment 379908 [details]
Patch
Comment 5 Carlos Garcia Campos 2019-10-01 09:14:42 PDT
Created attachment 379909 [details]
Fix WPE
Comment 6 Carlos Garcia Campos 2019-10-01 09:33:00 PDT
The linking errors fixed here just by doing a clean build.
Comment 7 Carlos Garcia Campos 2019-10-02 01:00:39 PDT
Committed r250597: <https://trac.webkit.org/changeset/250597>