Bug 20225 - [Qt] build failure after r35440
Summary: [Qt] build failure after r35440
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-30 02:12 PDT by Csaba Osztrogonác
Modified: 2008-07-30 12:37 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2008-07-30 02:12:26 PDT 
I think this code must be in #if USE(MULTIPLE_THREADS)... #endif block:

JavaScriptCore/kjs/collector.cpp line 126-128:
int error = pthread_key_create(&m_currentThreadRegistrar, unregisterThread); 
if (error) 
    CRASH();
---
Preprocessor don't find a header when processing JSContextRef.cpp:
JavaScriptCore/API/JSContextRef.h line 7:
#include <JavaScriptCore/WebKitAvailability.h>

I removed this line and all "AVAILABLE_AFTER_WEBKIT_VERSION_3_1" macros in JSContextRef.h, and it seems a useable but ugly workaround. 
---
With these workaround and with my patch submitted in bugzilla previously (https://bugs.webkit.org/show_bug.cgi?id=20170) r35444 was built correctly, and regression tests was succeeded.
Comment 1 Csaba Osztrogonác 2008-07-30 12:37:43 PDT 
Bugs fixed today, thanks:
multiple threads: http://trac.webkit.org/changeset/35452
WekitAvailability.h: http://trac.webkit.org/changeset/35449