Bug 20170 - [Qt] missing namespace defines in JavaScriptCore.pro
Summary: [Qt] missing namespace defines in JavaScriptCore.pro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-25 06:50 PDT by Gabor Loki
Modified: 2008-07-31 08:01 PDT (History)
1 user (show)

See Also:


Attachments
proposed fix (1.01 KB, patch)
2008-07-29 07:35 PDT, Csaba Osztrogonác
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2008-07-25 06:50:02 PDT
With Qt-4.3.4 there is a build error. The QT_BEGIN_NAMESPACE and QT_END_NAMESPACE macros are never defined (rev. 35342).

A similar patch is needed for JavaScriptCore.pro as http://trac.webkit.org/changeset/32306#file1 was.
Comment 1 Csaba Osztrogonác 2008-07-29 07:35:40 PDT
Created attachment 22538 [details]
proposed fix
Comment 2 Simon Hausmann 2008-07-31 06:00:01 PDT
Comment on attachment 22538 [details]
proposed fix

Thanks for the fix!
Comment 3 Simon Hausmann 2008-07-31 08:01:02 PDT
Landed in r35479