Bug 202123 - JavaScriptCore (still) doesn't unlock the engineering keychain
Summary: JavaScriptCore (still) doesn't unlock the engineering keychain
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks: 200733
  Show dependency tree / graph
 
Reported: 2019-09-23 16:43 PDT by Alexey Proskuryakov
Modified: 2019-09-24 12:23 PDT (History)
10 users (show)

See Also:

Attachments
proposed patch (2.30 KB, patch)
2019-09-23 16:48 PDT, Alexey Proskuryakov 		keith_miller: review+
Details | Formatted Diff | Diff
alternative fix (2.95 KB, patch)
2019-09-24 09:21 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2019-09-23 16:43:13 PDT 
Unlike WebKit, JavaScriptCore only defines CODE_SIGN_IDENTITY in ToolExecutable, not in DebugRelease. As a result, it's not defined when running the script for Unlock Keychain phase.
Comment 1 Alexey Proskuryakov 2019-09-23 16:48:43 PDT 
Created attachment 379408 [details]
proposed patch
Comment 2 Keith Miller 2019-09-23 16:52:05 PDT 
Comment on attachment 379408 [details]
proposed patch

r=me.
Comment 3 Alexey Proskuryakov 2019-09-23 17:02:27 PDT 
On the other hand, maybe we should start signing everything in the same way. Does anyone remember why only tool targets get CODE_SIGN_IDENTITY defined?
Comment 4 Tadeu Zagallo 2019-09-23 18:03:17 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> On the other hand, maybe we should start signing everything in the same way.
> Does anyone remember why only tool targets get CODE_SIGN_IDENTITY defined?

The only executable that actually needs signing is testapi, in order to test the bytecode cache, so I only added it to ToolExecutable... maybe it wasn't the best call.
Comment 5 Alexey Proskuryakov 2019-09-24 09:21:13 PDT 
Created attachment 379456 [details]
alternative fix

Alternative fix - just sign everything in JavaScriptCore, the same way it's done in WebKit.
Comment 6 WebKit Commit Bot 2019-09-24 12:22:29 PDT 
Comment on attachment 379456 [details]
alternative fix

Clearing flags on attachment: 379456

Committed r250314: <https://trac.webkit.org/changeset/250314>
Comment 7 WebKit Commit Bot 2019-09-24 12:22:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-09-24 12:23:16 PDT 
<rdar://problem/55672336>