WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
202123
JavaScriptCore (still) doesn't unlock the engineering keychain
https://bugs.webkit.org/show_bug.cgi?id=202123
Summary
JavaScriptCore (still) doesn't unlock the engineering keychain
Alexey Proskuryakov
Reported
2019-09-23 16:43:13 PDT
Unlike WebKit, JavaScriptCore only defines CODE_SIGN_IDENTITY in ToolExecutable, not in DebugRelease. As a result, it's not defined when running the script for Unlock Keychain phase.
Attachments
proposed patch
(2.30 KB, patch)
2019-09-23 16:48 PDT
,
Alexey Proskuryakov
keith_miller
: review+
Details
Formatted Diff
Diff
alternative fix
(2.95 KB, patch)
2019-09-24 09:21 PDT
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2019-09-23 16:48:43 PDT
Created
attachment 379408
[details]
proposed patch
Keith Miller
Comment 2
2019-09-23 16:52:05 PDT
Comment on
attachment 379408
[details]
proposed patch r=me.
Alexey Proskuryakov
Comment 3
2019-09-23 17:02:27 PDT
On the other hand, maybe we should start signing everything in the same way. Does anyone remember why only tool targets get CODE_SIGN_IDENTITY defined?
Tadeu Zagallo
Comment 4
2019-09-23 18:03:17 PDT
(In reply to Alexey Proskuryakov from
comment #3
)
> On the other hand, maybe we should start signing everything in the same way. > Does anyone remember why only tool targets get CODE_SIGN_IDENTITY defined?
The only executable that actually needs signing is testapi, in order to test the bytecode cache, so I only added it to ToolExecutable... maybe it wasn't the best call.
Alexey Proskuryakov
Comment 5
2019-09-24 09:21:13 PDT
Created
attachment 379456
[details]
alternative fix Alternative fix - just sign everything in JavaScriptCore, the same way it's done in WebKit.
WebKit Commit Bot
Comment 6
2019-09-24 12:22:29 PDT
Comment on
attachment 379456
[details]
alternative fix Clearing flags on attachment: 379456 Committed
r250314
: <
https://trac.webkit.org/changeset/250314
>
WebKit Commit Bot
Comment 7
2019-09-24 12:22:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2019-09-24 12:23:16 PDT
<
rdar://problem/55672336
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug