Bug 200733 - Make sure JSC tool targets unlock the keychain before codesigning
Summary: Make sure JSC tool targets unlock the keychain before codesigning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on: 202123
Blocks:
  Show dependency tree / graph
 
Reported: 2019-08-14 13:46 PDT by Tadeu Zagallo
Modified: 2019-09-23 16:43 PDT (History)
9 users (show)

See Also:

Attachments
Patch (13.17 KB, patch)
2019-08-14 13:51 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (12.94 KB, patch)
2019-08-19 14:00 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-08-14 13:46:52 PDT 
...
Comment 1 Tadeu Zagallo 2019-08-14 13:51:01 PDT 
Created attachment 376306 [details]
Patch
Comment 2 Alexey Proskuryakov 2019-08-14 16:54:51 PDT 
Comment on attachment 376306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376306&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:1919
> +			inputFiles = (
> +			);

Looks like an unrelated change.
Comment 3 Tadeu Zagallo 2019-08-19 14:00:14 PDT 
Comment on attachment 376306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376306&action=review

Thanks for the review!

>> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:1919
>> +			);
> 
> Looks like an unrelated change.

Oops, Xcode inserted this.
Comment 4 Tadeu Zagallo 2019-08-19 14:00:38 PDT 
Created attachment 376708 [details]
Patch for landing
Comment 5 Alexey Proskuryakov 2019-08-19 14:02:12 PDT 
rdar://problem/54223095
Comment 6 WebKit Commit Bot 2019-08-19 14:34:14 PDT 
Comment on attachment 376708 [details]
Patch for landing

Clearing flags on attachment: 376708

Committed r248866: <https://trac.webkit.org/changeset/248866>
Comment 7 WebKit Commit Bot 2019-08-19 14:34:15 PDT 
All reviewed patches have been landed.  Closing bug.