Bug 201947 - Stop calling WTF::initializeMainThread() in JSGlobalContextCreate*()
Summary: Stop calling WTF::initializeMainThread() in JSGlobalContextCreate*()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 200507
  Show dependency treegraph
 
Reported: 2019-09-18 15:02 PDT by Chris Dumez
Modified: 2019-09-18 16:23 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.15 KB, patch)
2019-09-18 15:04 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-18 15:02:46 PDT
Stop calling WTF::initializeMainThread() in JSGlobalContextCreate*(). I started doing so in <https://trac.webkit.org/changeset/248533> but it is causing crashes for apps using this JS API on background threads. It is also no longer necessary as of <https://trac.webkit.org/changeset/249064>.
Comment 1 Chris Dumez 2019-09-18 15:03:04 PDT
<rdar://problem/55453612>
Comment 2 Chris Dumez 2019-09-18 15:04:47 PDT
Created attachment 379077 [details]
Patch
Comment 3 Mark Lam 2019-09-18 15:08:30 PDT
Comment on attachment 379077 [details]
Patch

r=me if bots are green.
Comment 4 Chris Dumez 2019-09-18 15:56:23 PDT
Comment on attachment 379077 [details]
Patch

Clearing flags on attachment: 379077

Committed r250062: <https://trac.webkit.org/changeset/250062>
Comment 5 Chris Dumez 2019-09-18 15:56:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2019-09-18 16:23:41 PDT
FYI, I am looking into writing an API test for this, to avoid this happening again in the future.