Bug 201083 - Regression(r248533) Assertion hit in isMainThread() for some clients using WTF because the main thread is not initialized
Summary: Regression(r248533) Assertion hit in isMainThread() for some clients using WT...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 200507
  Show dependency tree / graph
 
Reported: 2019-08-23 12:09 PDT by Chris Dumez
Modified: 2019-09-18 15:05 PDT (History)
13 users (show)

See Also:

Attachments
Patch (4.29 KB, patch)
2019-08-23 12:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-23 12:09:14 PDT 
An assertion is hit in isMainThread() for some clients using WTF because the main thread is not initialized, since r248533.
Comment 1 Chris Dumez 2019-08-23 12:10:30 PDT 
Clients can work around this by calling WTF::initializeMainThread() before using WTF but it seems unfortunate to force them to do so. I propose we disable the assertion until the main thread is initialized.
Comment 2 Chris Dumez 2019-08-23 12:11:53 PDT 
Created attachment 377148 [details]
Patch
Comment 3 Chris Dumez 2019-08-23 12:14:40 PDT 
See <rdar://problem/54616639> & <rdar://problem/54323901>.
Comment 4 WebKit Commit Bot 2019-08-23 13:31:15 PDT 
Comment on attachment 377148 [details]
Patch

Clearing flags on attachment: 377148

Committed r249064: <https://trac.webkit.org/changeset/249064>
Comment 5 WebKit Commit Bot 2019-08-23 13:31:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-23 13:32:17 PDT 
<rdar://problem/54651993>
Comment 7 Fujii Hironori 2019-08-25 18:52:31 PDT 
Committed r249092: <https://trac.webkit.org/changeset/249092>
Comment 8 Chris Dumez 2019-08-26 09:16:44 PDT 
(In reply to Fujii Hironori from comment #7)
> Committed r249092: <https://trac.webkit.org/changeset/249092>

Thanks for the build fox :D