Bug 20194 - Uninitalized variables in RenderText.cpp
Summary: Uninitalized variables in RenderText.cpp
Status: RESOLVED DUPLICATE of bug 13864
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Nobody
Depends on:
Reported: 2008-07-28 04:29 PDT by Balazs Kelemen
Modified: 2008-07-28 08:22 PDT (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2008-07-28 04:29:12 PDT
We analyzed WebKit (r35407, qt-linux) with Valgrind and found that there is an execution path in RenderText.cpp
that use unitilazed variables.

If the "(!len || (stripFrontSpaces && m_text->containsOnlyWhitespace()))"
condition is true in RenderText::trimmedPrefWidths the function returns without initalizing beginWS and endWS (thes are the names of
the formal parameters and the variables that are given to the function too). After calling trimmedPrefWiths in
RenderBlock::calcInlinePrefWidths these variables are used to determine a condition in line 3866.

Declaration and use of the potentially uninitalized variables:
    Webkit/WebCore/rendering/RenderBlock.cpp - lines: 3856-3871
    bool hasBreakableChar, hasBreak;
    int beginMin, endMin;
    bool beginWS, endWS;
    int beginMax, endMax;
    t->trimmedPrefWidths(inlineMax, beginMin, beginWS, endMin, endWS,
                            hasBreakableChar, hasBreak, beginMax, endMax,
                            childMin, childMax, stripFrontSpaces);

    // This text object will not be rendered, but it may still provide a breaking opportunity.
    if (!hasBreak && childMax == 0) {
        if (autoWrap && (beginWS || endWS)) {
            m_minPrefWidth = max(inlineMin, m_minPrefWidth);
            inlineMin = 0;

The called function:
    Webkit/WebCore/rendering/RenderText.cpp - lines: 399-423
    void RenderText::trimmedPrefWidths(int leadWidth,
                                    int& beginMinW, bool& beginWS,
                                    int& endMinW, bool& endWS,
                                    bool& hasBreakableChar, bool& hasBreak,
                                    int& beginMaxW, int& endMaxW,
                                    int& minW, int& maxW, bool& stripFrontSpaces)
        bool collapseWhiteSpace = style()->collapseWhiteSpace();
        if (!collapseWhiteSpace)
            stripFrontSpaces = false;

        if (m_hasTab || prefWidthsDirty())

        int len = textLength();
        if (!len || (stripFrontSpaces && m_text->containsOnlyWhitespace())) {
            beginMinW = 0;
            endMinW = 0;
            beginMaxW = 0;
            endMaxW = 0;
            minW = 0;
            maxW = 0;
            hasBreak = false;
Comment 1 Mark Rowe (bdash) 2008-07-28 08:22:43 PDT

*** This bug has been marked as a duplicate of 13864 ***