As seen in imported/w3c/web-platform-tests/innerText/getter.html imported/w3c/web-platform-tests/html/dom/elements/the-innertext-idl-attribute/getter.html
Created attachment 378946 [details] patch
Comment on attachment 378946 [details] patch Attachment 378946 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13039446 New failing tests: imported/blink/fast/text/font-linux-normalize.html fast/tokenizer/script_extra_close.html editing/style/non-inheritable-styles.html
Created attachment 378954 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 378958 [details] patch
Created attachment 378959 [details] patch
Comment on attachment 378959 [details] patch Rejecting attachment 378959 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 378959, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Traceback (most recent call last): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: https://webkit-queues.webkit.org/results/13039995
Created attachment 378972 [details] patch
Comment on attachment 378972 [details] patch Clearing flags on attachment: 378972 Committed r249963: <https://trac.webkit.org/changeset/249963>
All reviewed patches have been landed. Closing bug.
<rdar://problem/55444205>
It looks like the changes in https://trac.webkit.org/changeset/249963/webkit broke media/track/track-cue-rendering-rtl.html It looks like this test no longer has some tabs and instead has spaces. could this be a rebasline? History: http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-cue-rendering-rtl.html Diff: --- /Volumes/Data/worker/iOS-12-Simulator-WK2-Tests-EWS/build/layout-test-results/media/track/track-cue-rendering-rtl-expected.txt +++ /Volumes/Data/worker/iOS-12-Simulator-WK2-Tests-EWS/build/layout-test-results/media/track/track-cue-rendering-rtl-actual.txt @@ -21,8 +21,8 @@ ** Jump to next cue ** EXPECTED (video.currentTime == '0.75') OK EXPECTED (testTrack.track.activeCues.length == '1') OK -EXPECTED (testTrack.track.activeCues[0].text == ' 1234') OK -EXPECTED (testCueDisplayBox.innerText == ' 1234') OK +EXPECTED (testTrack.track.activeCues[0].text == ' 1234') OK +EXPECTED (testCueDisplayBox.innerText == ' 1234') OK ** The position should be default and CSS direction set to ltr ** EXPECTED (2 * testCueDisplayBox.offsetLeft == video.videoWidth - testCueDisplayBox.offsetWidth == 'true') OK @@ -73,8 +73,8 @@ ** Jump to next cue ** EXPECTED (video.currentTime == '2.75') OK EXPECTED (testTrack.track.activeCues.length == '1') OK -EXPECTED (testTrack.track.activeCues[0].text == ' ०१२३४५६à¥à¥®à¥¯ ') OK -EXPECTED (testCueDisplayBox.innerText == ' ०१२३४५६à¥à¥®à¥¯ ') OK +EXPECTED (testTrack.track.activeCues[0].text == ' ०१२३४५६à¥à¥®à¥¯ ') OK +EXPECTED (testCueDisplayBox.innerText == ' ०१२३४५६à¥à¥®à¥¯ ') OK ** The position should be default and CSS direction set to ltr ** EXPECTED (2 * testCueDisplayBox.offsetLeft == video.videoWidth - testCueDisplayBox.offsetWidth == 'true') OK
(In reply to Truitt Savell from comment #11) > It looks like the changes in https://trac.webkit.org/changeset/249963/webkit > > broke media/track/track-cue-rendering-rtl.html > > It looks like this test no longer has some tabs and instead has spaces. > could this be a rebasline? I went ahead and rebaselined the test in https://trac.webkit.org/changeset/250022/webkit
Thanks!