RESOLVED FIXED Bug 201760
Eliminate separate simple line layout path from TextIterator 
https://bugs.webkit.org/show_bug.cgi?id=201760
Summary Eliminate separate simple line layout path from TextIterator
Antti Koivisto
Reported 2019-09-13 05:45:27 PDT
By using line layout iterator.
Attachments
wip (34.32 KB, patch)
2019-09-13 06:07 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (56.92 KB, patch)
2019-09-14 05:33 PDT, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (57.45 KB, patch)
2019-09-14 08:58 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (59.25 KB, patch)
2019-09-16 03:50 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (62.99 KB, patch)
2019-09-16 04:38 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-09-13 06:07:19 PDT
Created attachment 378726 [details] wip
Antti Koivisto
Comment 2 2019-09-14 05:33:56 PDT
Created attachment 378794 [details] patch
zalan
Comment 3 2019-09-14 05:46:46 PDT
Comment on attachment 378794 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=378794&action=review > Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp:105 > +// bool isSingleTab = !multipleWhitespace && m_currentSegment->text[m_currentSegment->toSegmentPosition(startPosition)] == '\t'; I guess this is a leftover
Antti Koivisto
Comment 4 2019-09-14 08:58:04 PDT
Created attachment 378799 [details] patch
Antti Koivisto
Comment 5 2019-09-16 03:50:26 PDT
Created attachment 378853 [details] patch
Antti Koivisto
Comment 6 2019-09-16 04:38:46 PDT
Created attachment 378854 [details] patch
WebKit Commit Bot
Comment 7 2019-09-16 07:31:43 PDT
Comment on attachment 378854 [details] patch Clearing flags on attachment: 378854 Committed r249895: <https://trac.webkit.org/changeset/249895>
WebKit Commit Bot
Comment 8 2019-09-16 07:31:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-16 07:32:17 PDT
<rdar://problem/55399318>
Note You need to log in before you can comment on or make changes to this bug.