Bug 201739 - getPropertyValue() and getComputedStyle() for text-rendering should return lower case string
Summary: getPropertyValue() and getComputedStyle() for text-rendering should return lo...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 200143
  Show dependency treegraph
 
Reported: 2019-09-12 13:36 PDT by Said Abou-Hallawa
Modified: 2022-02-26 02:44 PST (History)
11 users (show)

See Also:


Attachments
text-rendering (1.20 KB, image/svg+xml)
2019-09-12 13:36 PDT, Said Abou-Hallawa
no flags Details
Patch (5.96 KB, patch)
2021-09-17 09:12 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (10.71 KB, patch)
2021-09-17 10:14 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (10.06 KB, patch)
2021-09-17 11:53 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (10.01 KB, patch)
2021-09-19 05:15 PDT, Rob Buis
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2021-09-19 06:39 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (4.04 KB, patch)
2021-09-19 08:38 PDT, Rob Buis
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (67.86 KB, patch)
2021-09-19 11:04 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (78.57 KB, patch)
2021-09-19 12:52 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (79.16 KB, patch)
2021-09-19 23:01 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (79.74 KB, patch)
2021-09-20 00:33 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (141.79 KB, patch)
2021-09-20 07:41 PDT, Rob Buis
rbuis: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-09-12 13:36:32 PDT
Created attachment 378674 [details]
text-rendering

Open the attached test case.

Result: The computed style values for text-rendering are in camel case.
Expected: Like all the other computed style values, they should be in lower case.
Comment 2 Rob Buis 2021-09-17 09:12:05 PDT
Created attachment 438480 [details]
Patch
Comment 3 Rob Buis 2021-09-17 10:14:59 PDT
Created attachment 438487 [details]
Patch
Comment 4 Rob Buis 2021-09-17 11:53:13 PDT
Created attachment 438497 [details]
Patch
Comment 5 Darin Adler 2021-09-18 15:57:58 PDT
Comment on attachment 438497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438497&action=review

> Source/WebCore/ChangeLog:9
> +        Explicitly lowercase computed style values for the text-rendering property
> +        since it uses camelcase for some of its values.

This does not look like the right way to achieve this.

Why do we "use camelcase" for some of these values if that is not what is expected? That is what we should fix. We shouldn’t be converting to lowercase at the boundary like this.

Unless there is some context where the camel case values are needed? Does the standard actually require the camel case when specifying values and lowercase when inspecting them?
Comment 6 Rob Buis 2021-09-19 05:15:08 PDT
Created attachment 438590 [details]
Patch
Comment 7 Rob Buis 2021-09-19 06:39:31 PDT
Created attachment 438592 [details]
Patch
Comment 8 Rob Buis 2021-09-19 08:38:41 PDT
Created attachment 438595 [details]
Patch
Comment 9 Rob Buis 2021-09-19 11:04:33 PDT
Created attachment 438602 [details]
Patch
Comment 10 Rob Buis 2021-09-19 12:52:00 PDT
Created attachment 438612 [details]
Patch
Comment 11 Rob Buis 2021-09-19 23:01:36 PDT
Created attachment 438638 [details]
Patch
Comment 12 Rob Buis 2021-09-20 00:33:36 PDT
Created attachment 438642 [details]
Patch
Comment 13 Rob Buis 2021-09-20 07:41:22 PDT
Created attachment 438678 [details]
Patch
Comment 14 Tim Nguyen (:ntim) 2022-02-26 02:43:52 PST
Shouldn't we change the values to lowercase directly in https://webkit-search.igalia.com/webkit/rev/820cbd8df3d5043b61b3a8142e1df68b3efc3f6b/Source/WebCore/css/CSSValueKeywords.in#1080-1082 ?

+CC Antti who probably is a good person to look at this patch.