WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201638
UserMediaProcessManager is revoking sandbox extensions too aggressively
https://bugs.webkit.org/show_bug.cgi?id=201638
Summary
UserMediaProcessManager is revoking sandbox extensions too aggressively
youenn fablet
Reported
2019-09-10 04:03:38 PDT
UserMediaProcessManager is revoking sandbox extensions too aggressively
Attachments
Patch
(4.28 KB, patch)
2019-09-10 04:11 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(4.34 KB, patch)
2019-09-10 06:07 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2019-09-10 04:11:00 PDT
Created
attachment 378455
[details]
Patch
Eric Carlson
Comment 2
2019-09-10 05:59:22 PDT
Comment on
attachment 378455
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=378455&action=review
> Source/WebKit/ChangeLog:11 > + Sandbox revocation was sometimes happening when a page is being closed while another page from the same process is starting capture. > + In that case, revocation might happen while it should not. > + To prevent this, we do not revoke sandbox extensions if there are pending captures for a page of the process. > + Whenever a page does not have any pending capture, sandbox extensions may be revoked.
Nit: it is probably worth mentioning that these changes fixes an existing test.
youenn fablet
Comment 3
2019-09-10 06:07:49 PDT
Created
attachment 378458
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2019-09-10 06:52:43 PDT
Comment on
attachment 378458
[details]
Patch for landing Clearing flags on attachment: 378458 Committed
r249712
: <
https://trac.webkit.org/changeset/249712
>
WebKit Commit Bot
Comment 5
2019-09-10 06:52:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-09-10 06:53:13 PDT
<
rdar://problem/55220850
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug