Bug 200975 - Remove MediaStreamPrivate::scheduleDeferredTask
Summary: Remove MediaStreamPrivate::scheduleDeferredTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 201638
Blocks:
  Show dependency tree / graph
 
Reported: 2019-08-21 05:46 PDT by youenn fablet
Modified: 2019-09-10 09:07 PDT (History)
15 users (show)

See Also:

Attachments
Patch (4.29 KB, patch)
2019-08-21 06:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.03 KB, patch)
2019-08-23 07:35 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.07 KB, patch)
2019-08-26 01:41 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (18.42 KB, patch)
2019-09-10 04:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (18.19 KB, patch)
2019-09-10 08:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-08-21 05:46:18 PDT 
Remove MediaStreamPrivate::scheduleDeferredTask
Comment 1 youenn fablet 2019-08-21 06:06:58 PDT 
Created attachment 376868 [details]
Patch
Comment 2 youenn fablet 2019-08-23 07:35:08 PDT 
Created attachment 377126 [details]
Patch
Comment 3 youenn fablet 2019-08-26 01:41:04 PDT 
Created attachment 377235 [details]
Patch
Comment 4 WebKit Commit Bot 2019-09-06 08:49:45 PDT 
Comment on attachment 377235 [details]
Patch

Clearing flags on attachment: 377235

Committed r249574: <https://trac.webkit.org/changeset/249574>
Comment 5 WebKit Commit Bot 2019-09-06 08:49:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-06 08:50:20 PDT 
<rdar://problem/55113418>
Comment 7 Radar WebKit Bug Importer 2019-09-06 08:50:21 PDT 
<rdar://problem/55113419>
Comment 8 Alex Christensen 2019-09-07 14:52:53 PDT 
Comment on attachment 377235 [details]
Patch

This seems to have made the test fast/mediastream/media-stream-track-source-failure.html fail quite often, and it was passing almost always before.
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fmediastream%2Fmedia-stream-track-source-failure.html
Comment 9 youenn fablet 2019-09-09 07:57:33 PDT 
(In reply to Alex Christensen from comment #8)
> Comment on attachment 377235 [details]
> Patch
> 
> This seems to have made the test
> fast/mediastream/media-stream-track-source-failure.html fail quite often,
> and it was passing almost always before.
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Fmediastream%2Fmedia-stream-track-source-
> failure.html

Seems like a regression, I'll check that.
Comment 10 Ryan Haddad 2019-09-09 10:52:24 PDT 
Reverted r249574 for reason:

Caused fast/mediastream/media-stream-track-source-failure.html to become flaky.

Committed r249651: <https://trac.webkit.org/changeset/249651>
Comment 11 youenn fablet 2019-09-10 04:03:02 PDT 
> Caused fast/mediastream/media-stream-track-source-failure.html to become
> flaky.

The issue is that the media state gets updated synchronously and so no state update is seen by the test.
We just need to slightly change the test.
Comment 12 youenn fablet 2019-09-10 04:15:58 PDT 
Created attachment 378456 [details]
Patch
Comment 13 WebKit Commit Bot 2019-09-10 07:46:26 PDT 
Comment on attachment 378456 [details]
Patch

Rejecting attachment 378456 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 378456, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13019926
Comment 14 youenn fablet 2019-09-10 08:33:00 PDT 
Created attachment 378465 [details]
Patch for landing
Comment 15 WebKit Commit Bot 2019-09-10 09:06:58 PDT 
Comment on attachment 378465 [details]
Patch for landing

Clearing flags on attachment: 378465

Committed r249718: <https://trac.webkit.org/changeset/249718>
Comment 16 WebKit Commit Bot 2019-09-10 09:07:00 PDT 
All reviewed patches have been landed.  Closing bug.