Bug 201614 - [iOS] We sometimes attempt to use a terminated prewarmed WebContent process
Summary: [iOS] We sometimes attempt to use a terminated prewarmed WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-09 14:05 PDT by Chris Dumez
Modified: 2019-09-09 21:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.18 KB, patch)
2019-09-09 14:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (9.13 KB, patch)
2019-09-09 18:27 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-09 14:05:27 PDT
We sometimes attempt to use a terminated prewarmed WebContent process, in particular upon resuming the UIProcess from suspension and when the prewarmed process has been jetsammed while we were suspended. In this case, upon resuming, it may take a while to get the notification that the mach connection has been closed and we'll use the prewarmed process. When we finally end up getting the notification, it is too late. We notify the client and it usually shows a crash banner. Ideally, we would not use such process in the first place.

It is also arguable whether it makes sense to keep prewarmed processes around when the UIProcess gets suspended.
Comment 1 Chris Dumez 2019-09-09 14:05:53 PDT
<rdar://problem/54714507>
Comment 2 Chris Dumez 2019-09-09 14:13:18 PDT
Created attachment 378408 [details]
Patch
Comment 3 Geoffrey Garen 2019-09-09 16:16:21 PDT
Comment on attachment 378408 [details]
Patch

r=me if you update to resolve merge conflict
Comment 4 Chris Dumez 2019-09-09 18:27:35 PDT
Created attachment 378424 [details]
Patch
Comment 5 WebKit Commit Bot 2019-09-09 21:24:29 PDT
Comment on attachment 378424 [details]
Patch

Clearing flags on attachment: 378424

Committed r249703: <https://trac.webkit.org/changeset/249703>
Comment 6 WebKit Commit Bot 2019-09-09 21:24:30 PDT
All reviewed patches have been landed.  Closing bug.