Bug 201337 - [GTK] Build failure in Debian Stable and Ubuntu LTS bots
Summary: [GTK] Build failure in Debian Stable and Ubuntu LTS bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-30 04:42 PDT by Pablo Saavedra
Modified: 2019-08-30 05:53 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.33 KB, patch)
2019-08-30 04:44 PDT, Pablo Saavedra
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2019-08-30 04:42:10 PDT
Ubuntu LTS bot is failing: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/24412
Debian Stable bot is failing: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/24796

the error is due to the disassociation did in:

```
  Dissociate the WebPageProxy's identifier from the WebPage's
​  https://bugs.webkit.org/show_bug.cgi?id=201233

  (https://trac.webkit.org/changeset/249275/webkit/)

  svn diff -c  249275 
```


```
Index: Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
===================================================================
--- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm      (revision 249274)
+++ Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm      (revision 249275)
@@ -877,7 +877,7 @@
     [_contentView _webViewDestroyed];

     if (_remoteObjectRegistry)
-        _page->process().processPool().removeMessageReceiver(Messages::RemoteObjectRegistry::messageReceiverName(), _page->pageID());
+        _page->process().processPool().removeMessageReceiver(Messages::RemoteObjectRegistry::messageReceiverName(), _page->webPageID());
 #endif

     _page->close();
```
Comment 1 Pablo Saavedra 2019-08-30 04:44:41 PDT
Created attachment 377698 [details]
patch
Comment 2 WebKit Commit Bot 2019-08-30 05:53:00 PDT
Comment on attachment 377698 [details]
patch

Clearing flags on attachment: 377698

Committed r249323: <https://trac.webkit.org/changeset/249323>
Comment 3 WebKit Commit Bot 2019-08-30 05:53:02 PDT
All reviewed patches have been landed.  Closing bug.