Bug 201233 - Dissociate the WebPageProxy's identifier from the WebPage's
Summary: Dissociate the WebPageProxy's identifier from the WebPage's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 201225
  Show dependency tree / graph
 
Reported: 2019-08-28 13:58 PDT by Chris Dumez
Modified: 2019-09-05 03:56 PDT (History)
9 users (show)

See Also:

Attachments
WIP Patch (283.58 KB, patch)
2019-08-28 13:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (318.68 KB, patch)
2019-08-28 14:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (319.50 KB, patch)
2019-08-28 14:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (319.50 KB, patch)
2019-08-28 15:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (357.33 KB, patch)
2019-08-28 15:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-28 13:58:09 PDT 
Dissociate the WebPageProxy's identifier from the WebPage's to help support Bug 201225.
Comment 1 Chris Dumez 2019-08-28 13:59:46 PDT 
Created attachment 377477 [details]
WIP Patch
Comment 2 Chris Dumez 2019-08-28 14:17:51 PDT 
Created attachment 377485 [details]
WIP Patch
Comment 3 Chris Dumez 2019-08-28 14:29:48 PDT 
Created attachment 377489 [details]
WIP Patch
Comment 4 Chris Dumez 2019-08-28 15:25:36 PDT 
Created attachment 377495 [details]
WIP Patch
Comment 5 Chris Dumez 2019-08-28 15:53:58 PDT 
Created attachment 377500 [details]
Patch
Comment 6 Chris Dumez 2019-08-29 08:28:28 PDT 
Comment on attachment 377500 [details]
Patch

Clearing flags on attachment: 377500

Committed r249275: <https://trac.webkit.org/changeset/249275>
Comment 7 Chris Dumez 2019-08-29 08:28:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-08-29 08:29:17 PDT 
<rdar://problem/54837423>
Comment 9 Milan Crha 2019-09-02 22:58:44 PDT 
For the record, one part of bug #201033 contains a regression this change could cause, that webkit_web_page_get_id() doesn't match webkit_web_view_get_page_id() any more. The bug #201033 contains tests which prove it. More info there.